fixed oe_setup_addon unsafe with user inputs from addons settings

This commit is contained in:
Giovanni Cascione 2022-03-14 23:50:47 +01:00
parent 5d5a4567ad
commit 1f2e7b24bc

View File

@ -31,9 +31,9 @@ oe_setup_addon() {
if [ -f "$xml_file" ]; then if [ -f "$xml_file" ]; then
XML_SETTINGS_VER="$(xmlstarlet sel -t -m settings -v @version $xml_file)" XML_SETTINGS_VER="$(xmlstarlet sel -t -m settings -v @version $xml_file)"
if [ "$XML_SETTINGS_VER" = "2" ]; then if [ "$XML_SETTINGS_VER" = "2" ]; then
eval $(xmlstarlet sel -t -m settings/setting -v @id -o "=\"" -v . -o "\"" -n "$xml_file") eval $(xmlstarlet sel -t -m settings/setting -v @id -o "=" -v . -n "$xml_file" | sed -e "s/'/'\\\\''/g; s/=/='/; s/$/'/")
else else
eval $(xmlstarlet sel -t -m settings -m setting -v @id -o "=\"" -v @value -o "\"" -n "$xml_file") eval $(xmlstarlet sel -t -m settings -m setting -v @id -o "=" -v @value -n "$xml_file" | sed -e "s/'/'\\\\''/g; s/=/='/; s/$/'/")
fi fi
fi fi
done done