From 29d9d08e4940519cc822db7e45522fb705ce0bce Mon Sep 17 00:00:00 2001 From: Matthias Reichl Date: Sat, 16 Nov 2019 15:37:41 +0100 Subject: [PATCH] init: don't mount nfs shares with soft option by default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using the soft timeout option for NFS mounts is a really bad idea and the nfs(5) manpage explicitly warns about it's issues: NB: A so-called "soft" timeout can cause silent data corruption in certain cases. As such, use the soft op‐ tion only when client responsiveness is more important than data integrity. Using NFS over TCP or increasing the value of the retrans option may mitigate some of the risks of using the soft option. So don't enable it by default, anyone who feels keen to take the risk can specify it manually on kernel command line. Signed-off-by: Matthias Reichl --- packages/sysutils/busybox/scripts/init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sysutils/busybox/scripts/init b/packages/sysutils/busybox/scripts/init index 3f755efca5..a5fb91b3ff 100755 --- a/packages/sysutils/busybox/scripts/init +++ b/packages/sysutils/busybox/scripts/init @@ -203,7 +203,7 @@ mount_nfs() { [ "$NFS_OPTIONS" = "$1" ] && NFS_OPTIONS= - mount_common "$NFS_EXPORT" "$2" "$3,nolock,soft,timeo=3,retrans=2,rsize=32768,wsize=32768,$NFS_OPTIONS" "nfs" + mount_common "$NFS_EXPORT" "$2" "$3,nolock,rsize=32768,wsize=32768,$NFS_OPTIONS" "nfs" } mount_ubifs() {