From 7c35f31139121f5e27f0dfd116510deed2af1121 Mon Sep 17 00:00:00 2001 From: Stefan Saraev Date: Tue, 7 Apr 2015 11:34:08 +0300 Subject: [PATCH] cleanup TODO in * --- packages/mediacenter/kodi/package.mk | 10 +--------- packages/mediacenter/kodi/scripts/kodi-config | 2 +- packages/multimedia/libva/package.mk | 2 +- .../sysutils/busybox/profile.d/98-busybox.conf | 2 +- packages/sysutils/busybox/scripts/fs-resize | 1 - packages/sysutils/eventlircd/evmap/ircore.evmap | 2 +- packages/sysutils/systemd/package.mk | 2 +- packages/tools/installer/scripts/installer | 16 +--------------- packages/x11/driver/xf86-video-intel/package.mk | 2 +- scripts/build | 1 - scripts/unpack | 1 - 11 files changed, 8 insertions(+), 33 deletions(-) diff --git a/packages/mediacenter/kodi/package.mk b/packages/mediacenter/kodi/package.mk index a5a4a4ac24..90db28f239 100644 --- a/packages/mediacenter/kodi/package.mk +++ b/packages/mediacenter/kodi/package.mk @@ -86,7 +86,6 @@ else KODI_CEC="--disable-libcec" fi -# TODO remove KODI_RSXS="--disable-rsxs" KODI_PROJECTM="--disable-projectm" KODI_GOOM="--disable-goom" @@ -316,10 +315,7 @@ pre_configure_target() { cd $ROOT/$PKG_BUILD rm -rf .$TARGET_NAME -# kodi fails to build with LTO optimization if build without GOLD support - [ ! "$GOLD_SUPPORT" = "yes" ] && strip_lto - -# Todo: kodi segfaults on exit when building with LTO support +# kodi should never be built with lto strip_lto export CFLAGS="$CFLAGS $KODI_CFLAGS" @@ -420,10 +416,6 @@ post_install() { # link default.target to kodi.target ln -sf kodi.target $INSTALL/usr/lib/systemd/system/default.target -# TODO: for compatibility to be removed soon - ln -sf kodi.target $INSTALL/usr/lib/systemd/system/xbmc.target - ln -sf kodi.service $INSTALL/usr/lib/systemd/system/xbmc.service - # enable default services enable_service kodi-autostart.service enable_service kodi-cleanlogs.service diff --git a/packages/mediacenter/kodi/scripts/kodi-config b/packages/mediacenter/kodi/scripts/kodi-config index 9af49ca6b6..261e9cfb3b 100755 --- a/packages/mediacenter/kodi/scripts/kodi-config +++ b/packages/mediacenter/kodi/scripts/kodi-config @@ -19,7 +19,7 @@ # hack: make addon-bins executable -# TODO remove +# done in kodi on addon install. but just in case.. chmod +x /storage/.kodi/addons/*/bin/* # hack: update RSSnews.xml in userdata diff --git a/packages/multimedia/libva/package.mk b/packages/multimedia/libva/package.mk index a34404afbc..6b61c4d296 100644 --- a/packages/multimedia/libva/package.mk +++ b/packages/multimedia/libva/package.mk @@ -43,7 +43,7 @@ PKG_CONFIGURE_OPTS_TARGET="--disable-silent-rules \ --with-drivers-path=/usr/lib/va" pre_configure_target() { -# todo: libva fails to build in subdirs +# libva fails to build in subdirs cd $ROOT/$PKG_BUILD rm -rf .$TARGET_NAME } diff --git a/packages/sysutils/busybox/profile.d/98-busybox.conf b/packages/sysutils/busybox/profile.d/98-busybox.conf index a42da2ed36..a5cc8ce02d 100644 --- a/packages/sysutils/busybox/profile.d/98-busybox.conf +++ b/packages/sysutils/busybox/profile.d/98-busybox.conf @@ -21,7 +21,7 @@ export PATH="/bin:/sbin:/usr/bin:/usr/sbin" export LD_LIBRARY_PATH="/usr/lib:/lib" export HOSTNAME=`cat /etc/hostname` export PS1="\[\e[1;32m\]\h\[\e[1;32m\]:\[\e[1;34m\]\w \[\e[0m\]\\$ " -# TODO: k0p: remove this and/or force TERM=xterm ? ping dag- +# k0p case "$TERM" in linux|nxterm|screen|xterm|xterm-color) ;; diff --git a/packages/sysutils/busybox/scripts/fs-resize b/packages/sysutils/busybox/scripts/fs-resize index 6ca06042e0..192723c694 100755 --- a/packages/sysutils/busybox/scripts/fs-resize +++ b/packages/sysutils/busybox/scripts/fs-resize @@ -51,7 +51,6 @@ if [ -e /storage/.please_resize_me ] ; then # failed to get partition start offset ? if [ ! -z "$PART_START" ] ; then umount $PART - # TODO: clean up debug echo "resizing /storage..." echo "this may take a while. please do not reboot or turn off your computer" echo "... parted -s -m $DISK rm 2" diff --git a/packages/sysutils/eventlircd/evmap/ircore.evmap b/packages/sysutils/eventlircd/evmap/ircore.evmap index 9983fc44c8..c186264c56 100644 --- a/packages/sysutils/eventlircd/evmap/ircore.evmap +++ b/packages/sysutils/eventlircd/evmap/ircore.evmap @@ -38,7 +38,7 @@ KEY_EPG = KEY_EPG KEY_ENTER = KEY_OK KEY_PLAYPAUSE = KEY_PLAY KEY_TITLE = KEY_SUBTITLE -KEY_CONTEXT_MENU = KEY_EPG # used for context menu # todo +KEY_CONTEXT_MENU = KEY_EPG # used for context menu KEY_EJECTCLOSECD = KEY_EJECT KEY_EJECTCD = KEY_EJECT diff --git a/packages/sysutils/systemd/package.mk b/packages/sysutils/systemd/package.mk index 21802d17a0..88c615bc00 100644 --- a/packages/sysutils/systemd/package.mk +++ b/packages/sysutils/systemd/package.mk @@ -232,7 +232,7 @@ post_install() { add_group tty 5 add_group video 39 add_group utmp 22 - add_group input 199 # TODO change gid + add_group input 199 enable_service machine-id.service enable_service debugconfig.service diff --git a/packages/tools/installer/scripts/installer b/packages/tools/installer/scripts/installer index 3d952965ee..cda54db6b5 100755 --- a/packages/tools/installer/scripts/installer +++ b/packages/tools/installer/scripts/installer @@ -553,11 +553,6 @@ msg_progress_install() { prompt_gpt() { GPT="0" UEFI="0" - # Get "msdos" or "gpt". TODO: remove. does this make sense ? - #INSTALL_DEVICE_PARTITION_TYPE=$(parted -s -m $INSTALL_DEVICE print | grep $INSTALL_DEVICE | cut -f6 -d ":") - #if [ "$INSTALL_DEVICE_PARTITION_TYPE" = "gpt" ]; then - # GPT="1" - #fi # Get size in GB. INSTALL_DEVICE_SIZE=$(($(cat /sys/block/${INSTALL_DEVICE#/dev/}/size)*512/1000/1000/1000)) if [ "$INSTALL_DEVICE_SIZE" -ge 2200 ] 2>/dev/null; then @@ -607,7 +602,6 @@ menu_main() { MSG_MENU="\n\ZbQuick Install:\Zn do a default installation on a specific device \ \Z1\Zb(this will delete ALL data on this device!)\Zn \ \n\ZbRepair / Upgrade:\Zn do repair / upgrade \ - \n\ZbSetup:\Zn change some settings to run OpenELEC \ \n\ZbShow logfile:\Zn show and save the logfile \ \n \ \nPlease select:" @@ -626,8 +620,7 @@ menu_main() { case $ITEM_MAINMENU in 1) do_install_quick; break;; 2) do_install_custom; break;; - 3) menu_setup; break;; - 4) logfile_show; break;; + 3) logfile_show; break;; esac ;; 1) @@ -639,14 +632,7 @@ menu_main() { esac } -menu_setup() { - # TODO: show the setupmenu - msg_not_implemented - menu_main -} - logfile_show() { - # TODO: show the logfile dialog --textbox "$LOGFILE" 20 70 clear menu_main diff --git a/packages/x11/driver/xf86-video-intel/package.mk b/packages/x11/driver/xf86-video-intel/package.mk index 230ba92a8c..e1ea9be611 100644 --- a/packages/x11/driver/xf86-video-intel/package.mk +++ b/packages/x11/driver/xf86-video-intel/package.mk @@ -57,7 +57,7 @@ PKG_CONFIGURE_OPTS_TARGET="--disable-backlight \ --with-xorg-module-dir=$XORG_PATH_MODULES" pre_configure_target() { -# TODO: xf86-video-intel-2.21.5 dont link with LTO enabled +# xf86-video-intel is broken enough. dont link with LTO strip_lto } diff --git a/scripts/build b/scripts/build index c7130a8ea3..8c03b305c1 100755 --- a/scripts/build +++ b/scripts/build @@ -354,7 +354,6 @@ if [ ! -f $STAMP ]; then cd $ROOT fi # ! "$PKG_SECTION" = "virtual" - # TODO: slow... for i in `find $SYSROOT_PREFIX/usr/lib/ -name "*.la" 2>/dev/null`; do \ $SED "s:\(['= ]\)/usr:\\1$SYSROOT_PREFIX/usr:g" $i; \ done diff --git a/scripts/unpack b/scripts/unpack index 7924ac1b41..553591ce7f 100755 --- a/scripts/unpack +++ b/scripts/unpack @@ -55,7 +55,6 @@ for i in $BUILD/$1-*; do fi done # trigger unpack / full rebuild on any patch / script / etc.. change - # TODO: rewwork $PKG_DIR/scripts -> $PKG_DIR/filesystem/.... for file in $PKG_DIR/{patches,scripts,config}/* $PKG_DIR/patches/$PKG_VERSION/*.patch $PROJECT_DIR/$PROJECT/patches/$PKG_NAME/*.patch; do if [ -f "$file" -a "$file" -nt "$i/.openelec-unpack" ]; then CLEAN_SOURCE=yes