From 7f2318b2b1f278d7df601bec0cbc88728f3ee2f1 Mon Sep 17 00:00:00 2001 From: Matthias Reichl Date: Mon, 8 Feb 2021 10:46:44 +0100 Subject: [PATCH 1/2] virtual/debug: allow including valgrind in non-debug builds valgrind can be useful to check if memory allocation is OK in release builds and to check for issues that don't occur in debug builds. As valgrind needs to be explicitly enabled removing the debug-only restriction has no impact on normal builds. Signed-off-by: Matthias Reichl --- packages/virtual/debug/package.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/virtual/debug/package.mk b/packages/virtual/debug/package.mk index 23d9254b78..fc431a8148 100644 --- a/packages/virtual/debug/package.mk +++ b/packages/virtual/debug/package.mk @@ -21,7 +21,7 @@ if [ "${VAAPI_SUPPORT}" = "yes" ]; then PKG_DEPENDS_TARGET+=" libva-utils" fi -if build_with_debug && [ "${VALGRIND}" = "yes" ]; then +if [ "${VALGRIND}" = "yes" ]; then PKG_DEPENDS_TARGET+=" valgrind" fi From b30315f5ba266430ba6efea9b78d04c5aeffadd6 Mon Sep 17 00:00:00 2001 From: Matthias Reichl Date: Mon, 8 Feb 2021 10:53:55 +0100 Subject: [PATCH 2/2] remove VALGRIND="no" from options files valgrind is only included if VALGRIND is explicitly set to "yes", setting it to "no" in some options files is not needed. Signed-off-by: Matthias Reichl --- projects/Amlogic/options | 4 ---- projects/RPi/options | 4 ---- projects/Samsung/options | 4 ---- 3 files changed, 12 deletions(-) diff --git a/projects/Amlogic/options b/projects/Amlogic/options index b12a3c8eb4..73612e580c 100644 --- a/projects/Amlogic/options +++ b/projects/Amlogic/options @@ -60,10 +60,6 @@ # build with installer (yes / no) INSTALLER_SUPPORT="no" - # build debug with valgrind (yes / no) - # Increases image size significantly - VALGRIND="no" - # additional drivers to install: # for a list of additional drivers see packages/linux-drivers # Space separated list is supported, diff --git a/projects/RPi/options b/projects/RPi/options index df6a0cc290..da37a4a681 100644 --- a/projects/RPi/options +++ b/projects/RPi/options @@ -101,10 +101,6 @@ # build with installer (yes / no) INSTALLER_SUPPORT="no" - # build debug with valgrind (yes / no) - # Not available for armv6. Increases image size significantly - VALGRIND="no" - # kernel image name KERNEL_NAME="kernel.img" diff --git a/projects/Samsung/options b/projects/Samsung/options index 177a08c8ea..1d7b976803 100644 --- a/projects/Samsung/options +++ b/projects/Samsung/options @@ -62,10 +62,6 @@ # build with installer (yes / no) INSTALLER_SUPPORT="no" - # build debug with valgrind (yes / no) - # Increases image size significantly - VALGRIND="no" - # additional packages to install: # Space separated list is supported, # e.g. ADDITIONAL_PACKAGES="PACKAGE1 PACKAGE2"