From c3f556486eae3eaffb868ab8b65191026149b4e7 Mon Sep 17 00:00:00 2001 From: James Belchamber Date: Sat, 17 Aug 2013 23:22:42 +0100 Subject: [PATCH 1/2] Added wildcard to mmcblk/loop if statement This wound me up no end until I realised it was only checking for mmcblk0. My chromebook has mmcblk0 in use so the sd card was showing up as mmcblk1. It's also not inconceivable for people to have more than one SD card plugged in at once. --- packages/tools/bcm2835-bootloader/files/create_sdcard | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/tools/bcm2835-bootloader/files/create_sdcard b/packages/tools/bcm2835-bootloader/files/create_sdcard index a66a3cc5d7..3bd4f850dd 100755 --- a/packages/tools/bcm2835-bootloader/files/create_sdcard +++ b/packages/tools/bcm2835-bootloader/files/create_sdcard @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash ################################################################################ # This file is part of OpenELEC - http://www.openelec.tv @@ -50,10 +50,10 @@ if [ -z "$1" ]; then fi DISK="$1" -if [ "$DISK" = "/dev/mmcblk0" ]; then +if [[ "$DISK" = "/dev/mmcblk"* ]]; then PART1="${DISK}p1" PART2="${DISK}p2" -elif [ "$DISK" = "/dev/loop0" ]; then +elif [[ "$DISK" = "/dev/loop"* ]]; then PART1="${DISK}p1" PART2="${DISK}p2" IMGFILE="$2" From 76cc52961701f8632cc2d8735460ab650a87a27b Mon Sep 17 00:00:00 2001 From: James Belchamber Date: Sun, 1 Sep 2013 12:41:19 +0100 Subject: [PATCH 2/2] Replaced if with case Because bash is the devil ;) --- .../bcm2835-bootloader/files/create_sdcard | 27 ++++++++++--------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/packages/tools/bcm2835-bootloader/files/create_sdcard b/packages/tools/bcm2835-bootloader/files/create_sdcard index 3bd4f850dd..b0757618a1 100755 --- a/packages/tools/bcm2835-bootloader/files/create_sdcard +++ b/packages/tools/bcm2835-bootloader/files/create_sdcard @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh ################################################################################ # This file is part of OpenELEC - http://www.openelec.tv @@ -50,18 +50,19 @@ if [ -z "$1" ]; then fi DISK="$1" -if [[ "$DISK" = "/dev/mmcblk"* ]]; then - PART1="${DISK}p1" - PART2="${DISK}p2" -elif [[ "$DISK" = "/dev/loop"* ]]; then - PART1="${DISK}p1" - PART2="${DISK}p2" - IMGFILE="$2" - losetup $DISK $IMGFILE -else - PART1="${DISK}1" - PART2="${DISK}2" -fi +case $DISK in + "/dev/mmcblk1"*) + PART1="${DISK}p1"; + PART2="${DISK}p2";; + "/dev/loop"*) + PART1="${DISK}p1"; + PART2="${DISK}p2"; + IMGFILE="$2"; + losetup $DISK $IMGFILE;; + *) + PART1="${DISK}1"; + PART2="${DISK}2";; +esac clear echo "#########################################################"