samba: call smbd-config from samba-config

packages/network/samba/package.mk

@@ -142,6 +142,8 @@ post_makeinstall_target() {
 
   mkdir -p $INSTALL/usr/lib/samba
     cp $PKG_DIR/scripts/samba-config $INSTALL/usr/lib/samba
+    cp $PKG_DIR/scripts/smbd-config $INSTALL/usr/lib/samba
+    cp $PKG_DIR/scripts/samba-autoshare $INSTALL/usr/lib/samba
 
   if find_file_path config/smb.conf; then
     mkdir -p $INSTALL/etc/samba
@@ -166,10 +168,6 @@ post_makeinstall_target() {
 
     mkdir -p $INSTALL/usr/share/services
       cp -P $PKG_DIR/default.d/*.conf $INSTALL/usr/share/services
-
-    mkdir -p $INSTALL/usr/lib/samba
-      cp $PKG_DIR/scripts/samba-autoshare $INSTALL/usr/lib/samba
-      cp $PKG_DIR/scripts/smbd-config $INSTALL/usr/lib/samba
   fi
 }
 

packages/network/samba/scripts/samba-autoshare

@@ -22,7 +22,6 @@ if [ -f /storage/.cache/services/samba.conf ]; then
 
   if [ "$SAMBA_AUTOSHARE" == "true" ] ; then
     /usr/lib/samba/samba-config
-    /usr/lib/samba/smbd-config
     [ -f /run/samba/smbd.pid ] && pkill -HUP smbd
   fi
 fi

packages/network/samba/scripts/samba-config

@@ -46,3 +46,10 @@ mkdir -p $(dirname $SMB_CONF)
   else
     cp $SMB_DEFCONF $SMB_CONF
   fi
+
+# Generate smb.conf, unless disabled
+if [ ! -f /storage/.cache/services/samba.disabled ]; then
+  /usr/lib/samba/smbd-config
+fi
+
+exit 0

packages/network/samba/system.d.opt/smbd.service

@@ -9,7 +9,6 @@ Wants=samba-config.service
 Type=forking
 PIDFile=/run/samba/smbd.pid
 LimitNOFILE=16384
-ExecStartPre=/usr/lib/samba/smbd-config
 ExecStart=/usr/sbin/smbd
 ExecReload=/bin/kill -HUP $MAINPID
 TimeoutStopSec=1s