jeans/Tasmota
jeans/Tasmota
1
0
Fork 0
mirror of https://github.com/arendst/Tasmota.git synced 2025-07-23 10:46:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

#18548 fix shuttersetup (#18586)

Browse Source 
- code optimization
- shuttersetup reluctant on relay to energy measure relation
This commit is contained in:
stefanbode 2023-05-06 15:46:29 +02:00 committed by GitHub
parent 8b2539a35a
commit 25e55ae073
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 46 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

105
tasmota/tasmota_xdrv_driver/xdrv_27_esp32_shutter.ino
View File

@ -50,6 +50,10 @@
#undef MAX_SHUTTERS_ESP32 #undef MAX_SHUTTERS_ESP32
#define MAX_SHUTTERS_ESP32 16 #define MAX_SHUTTERS_ESP32 16
// Define Std Text Strings
#define D_ERROR_FILESYSTEM_NOT_READY "SHT: ERROR File system not enabled"
#define D_ERROR_FILE_NOT_FOUND "SHT: ERROR File system not ready or file not found"
// //
const uint32_t SHUTTER_VERSION = 0x01010100; // Latest driver version (See settings deltas below) const uint32_t SHUTTER_VERSION = 0x01010100; // Latest driver version (See settings deltas below)
@ -271,12 +275,12 @@ void ShutterSettingsDelta(void) {
} }
} }
/*
if (ShutterSettings.version < 0x01010101) {
AddLog(LOG_LEVEL_INFO, PSTR("SHT: Update old version restore"));
} // if (ShutterSettings.version < 0x01010101) {
*/ // AddLog(LOG_LEVEL_INFO, PSTR("SHT: Update old version restore"));
// }
// Set current version and save settings // Set current version and save settings
ShutterSettings.version = SHUTTER_VERSION; ShutterSettings.version = SHUTTER_VERSION;
ShutterSettingsSave(); ShutterSettingsSave();
@ -291,12 +295,10 @@ void ShutterSettingsLoad(bool erase) {
// Try to load file /.drvset027 // Try to load file /.drvset027
char filename[20]; char filename[20];
// Use for sensors:
// snprintf_P(filename, sizeof(filename), PSTR(TASM_FILE_SENSOR), XSNS_27);
// Use for drivers: // Use for drivers:
snprintf_P(filename, sizeof(filename), PSTR(TASM_FILE_DRIVER), XDRV_27); snprintf_P(filename, sizeof(filename), PSTR(TASM_FILE_DRIVER), XDRV_27);
AddLog(LOG_LEVEL_INFO, PSTR("SHUTTER: About to load settings from file %s"), filename); AddLog(LOG_LEVEL_INFO, PSTR("SHT: About to load settings from file %s"), filename);
#ifdef USE_UFILESYS #ifdef USE_UFILESYS
if (erase) { if (erase) {
@ -307,11 +309,11 @@ void ShutterSettingsLoad(bool erase) {
ShutterSettingsDelta(); ShutterSettingsDelta();
} else { } else {
// File system not ready: No flash space reserved for file system // File system not ready: No flash space reserved for file system
AddLog(LOG_LEVEL_INFO, PSTR("DRV: ERROR File system not ready or file not found")); AddLog(LOG_LEVEL_INFO, PSTR(D_ERROR_FILE_NOT_FOUND));
} }
#else #else
AddLog(LOG_LEVEL_INFO, PSTR("DRV: ERROR File system not enabled")); AddLog(LOG_LEVEL_INFO, D_ERROR_FILESYSTEM_NOT_READY);
#endif // USE_UFILESYS #endif // USE_UFILESYS
} }
@ -324,20 +326,18 @@ void ShutterSettingsSave(void) {
ShutterSettings.crc32 = crc32; ShutterSettings.crc32 = crc32;
char filename[20]; char filename[20];
// Use for sensors:
// snprintf_P(filename, sizeof(filename), PSTR(TASM_FILE_SENSOR), XSNS_27);
// Use for drivers: // Use for drivers:
snprintf_P(filename, sizeof(filename), PSTR(TASM_FILE_DRIVER), XDRV_27); snprintf_P(filename, sizeof(filename), PSTR(TASM_FILE_DRIVER), XDRV_27);
AddLog(LOG_LEVEL_INFO, PSTR("SHUTTER: About to save settings to file %s"), filename); AddLog(LOG_LEVEL_INFO, PSTR("SHT: About to save settings to file %s"), filename);
#ifdef USE_UFILESYS #ifdef USE_UFILESYS
if (!TfsSaveFile(filename, (const uint8_t*)&ShutterSettings, sizeof(ShutterSettings))) { if (!TfsSaveFile(filename, (const uint8_t*)&ShutterSettings, sizeof(ShutterSettings))) {
// File system not ready: No flash space reserved for file system // File system not ready: No flash space reserved for file system
AddLog(LOG_LEVEL_INFO, PSTR("DRV: ERROR File system not ready or unable to save file")); AddLog(LOG_LEVEL_INFO, D_ERROR_FILE_NOT_FOUND);
} }
#else #else
AddLog(LOG_LEVEL_INFO, PSTR("SHUTTER: ERROR File system not enabled")); AddLog(LOG_LEVEL_INFO, D_ERROR_FILESYSTEM_NOT_READY);
#endif // USE_UFILESYS #endif // USE_UFILESYS
} }
} }
@ -903,7 +903,7 @@ void ShutterUpdatePosition(void)
XnrgCall(FUNC_ENERGY_EVERY_SECOND); XnrgCall(FUNC_ENERGY_EVERY_SECOND);
// fency calculation with direction gives index 0 and 1 of the energy meter // fency calculation with direction gives index 0 and 1 of the energy meter
// stop if endpoint is reached // stop if endpoint is reached
if (Energy->active_power[(1 - Shutter[i].direction ) / 2] < 1.0 && Shutter[i].time > 20){ if (Energy->active_power[0]+Energy->active_power[1] < 1.0 && Shutter[i].time > 20){
ShutterGlobal.stopp_armed++; ShutterGlobal.stopp_armed++;
AddLog(LOG_LEVEL_INFO, PSTR("SHT: stopp_armed:%d"),ShutterGlobal.stopp_armed); AddLog(LOG_LEVEL_INFO, PSTR("SHT: stopp_armed:%d"),ShutterGlobal.stopp_armed);
if (ShutterGlobal.stopp_armed > 2) { if (ShutterGlobal.stopp_armed > 2) {
@ -1058,6 +1058,7 @@ int32_t ShutterCalculatePosition(uint32_t i)
case SHT_TIME_UP_DOWN: case SHT_TIME_UP_DOWN:
case SHT_TIME_GARAGE: case SHT_TIME_GARAGE:
if (Shutter[i].tilt_config[2] > 0) { if (Shutter[i].tilt_config[2] > 0) {
// the tilt time is defined and therefore the tiltposition must be calculated
if (Shutter[i].time <= Shutter[i].venetian_delay+Shutter[i].motordelay) { if (Shutter[i].time <= Shutter[i].venetian_delay+Shutter[i].motordelay) {
Shutter[i].tilt_real_pos = (Shutter[i].tilt_start_pos + ((Shutter[i].direction * (int16_t)(Shutter[i].time - tmin(Shutter[i].motordelay, Shutter[i].time)) * (Shutter[i].tilt_config[1]-Shutter[i].tilt_config[0])) / Shutter[i].tilt_config[2])); Shutter[i].tilt_real_pos = (Shutter[i].tilt_start_pos + ((Shutter[i].direction * (int16_t)(Shutter[i].time - tmin(Shutter[i].motordelay, Shutter[i].time)) * (Shutter[i].tilt_config[1]-Shutter[i].tilt_config[0])) / Shutter[i].tilt_config[2]));
} else { } else {
@ -1114,53 +1115,39 @@ void ShutterRelayChanged(void)
if (powerstate_local > 0) { if (powerstate_local > 0) {
Shutter[i].tiltmoving = 0; Shutter[i].tiltmoving = 0;
} }
switch (ShutterGlobal.position_mode) { switch (ShutterGlobal.position_mode) {
// enum Shutterposition_mode {SHT_TIME, SHT_TIME_UP_DOWN, SHT_TIME_GARAGE, SHT_COUNTER, SHT_PWM_VALUE, SHT_PWM_TIME,}; // enum Shutterposition_mode {SHT_TIME, SHT_TIME_UP_DOWN, SHT_TIME_GARAGE, SHT_COUNTER, SHT_PWM_VALUE, SHT_PWM_TIME,};
case SHT_TIME_UP_DOWN: case SHT_TIME_UP_DOWN:
case SHT_COUNTER: case SHT_COUNTER:
case SHT_PWM_VALUE: case SHT_PWM_VALUE:
case SHT_PWM_TIME: case SHT_PWM_TIME:
//AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: power off manual change")); case SHT_TIME: {
ShutterPowerOff(i); ShutterPowerOff(i);
switch (powerstate_local) { // powerstate_local == 0 => direction=0, stop
case 1: // powerstate_local == 1 => direction=1, target=Shutter[i].open_max
ShutterStartInit(i, 1, Shutter[i].open_max); // powerstate_local == 2 => direction=-1, target=0 // only happen on SHT_TIME
break; // powerstate_local == 3 => direction=-1, target=0 // only happen if NOT SHT_TIME
case 3: int direction = (powerstate_local == 0) ? 0 : (powerstate_local == 1) ? 1 : -1;
ShutterStartInit(i, -1, 0); int target = (powerstate_local == 1) ? Shutter[i].open_max : 0;
break;
default: if (direction != 0) {
//AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: Shtr%d Switch OFF motor."),i); ShutterStartInit(i, direction, target);
} else {
Shutter[i].target_position = Shutter[i].real_position; Shutter[i].target_position = Shutter[i].real_position;
Shutter[i].last_stop_time = millis(); Shutter[i].last_stop_time = millis();
} }
break; break;
case SHT_TIME:
switch (powerstate_local) {
case 1:
ShutterStartInit(i, 1, Shutter[i].open_max);
break;
case 2:
ShutterStartInit(i, -1, 0);
break;
default:
//AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: Shtr%d Switch OFF motor."),i+1);
Shutter[i].target_position = Shutter[i].real_position;
Shutter[i].last_stop_time = millis();
} }
break; case SHT_TIME_GARAGE:
case SHT_TIME_GARAGE: switch (powerstate_local) {
switch (powerstate_local) { case 1:
case 1: ShutterStartInit(i, Shutter[i].lastdirection * -1, Shutter[i].lastdirection == 1 ? 0 : Shutter[i].open_max);
ShutterStartInit(i, Shutter[i].lastdirection*-1 , Shutter[i].lastdirection == 1 ? 0 : Shutter[i].open_max); AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: Shtr%d Garage. NewTarget %d"), i, Shutter[i].target_position);
AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: Shtr%d Garage. NewTarget %d"), i, Shutter[i].target_position); break;
break; default:
default: Shutter[i].target_position = Shutter[i].real_position;
Shutter[i].target_position = Shutter[i].real_position; }
} }
} // switch (ShutterGlobal.position_mode)
AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: Shtr%d, Target %ld, Power: %d, tiltmv: %d"), i+1, Shutter[i].target_position, powerstate_local,Shutter[i].tiltmoving); AddLog(LOG_LEVEL_DEBUG_MORE, PSTR("SHT: Shtr%d, Target %ld, Power: %d, tiltmv: %d"), i+1, Shutter[i].target_position, powerstate_local,Shutter[i].tiltmoving);
} // if (manual_relays_changed) } // if (manual_relays_changed)
} // for (uint32_t i = 0; i < TasmotaGlobal.shutters_present; i++) } // for (uint32_t i = 0; i < TasmotaGlobal.shutters_present; i++)