From 1121a149950d60ed73c4aa24a93b3524a042b463 Mon Sep 17 00:00:00 2001 From: RevK Date: Sat, 13 Apr 2019 06:49:37 +0100 Subject: [PATCH 1/3] Fix use of SerialDelimiter value 128 --- sonoff/_changelog.ino | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sonoff/_changelog.ino b/sonoff/_changelog.ino index 4698dc463..2d6a4745e 100644 --- a/sonoff/_changelog.ino +++ b/sonoff/_changelog.ino @@ -1,4 +1,7 @@ -/* 6.5.0.7 20190410 +/* 6.5.0.8 20190412 + * Fix use of SerialDelimiter value 128 + * + * 6.5.0.7 20190410 * Add command LedMask to assign which relay has access to power LED (#5602, #5612) * * 6.5.0.6 20190409 From 6d391103d7b850847a550a0005f3b875c68e7dfa Mon Sep 17 00:00:00 2001 From: RevK Date: Sat, 13 Apr 2019 06:50:04 +0100 Subject: [PATCH 2/3] Fix use of SerialDelimiter value 128 --- sonoff/sonoff_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonoff/sonoff_version.h b/sonoff/sonoff_version.h index 30b6cc65e..c0399c306 100644 --- a/sonoff/sonoff_version.h +++ b/sonoff/sonoff_version.h @@ -20,6 +20,6 @@ #ifndef _SONOFF_VERSION_H_ #define _SONOFF_VERSION_H_ -const uint32_t VERSION = 0x06050007; +const uint32_t VERSION = 0x06050008; #endif // _SONOFF_VERSION_H_ From 7d055b22718b48b713f29bc4e5cbf025a591ff07 Mon Sep 17 00:00:00 2001 From: RevK Date: Sat, 13 Apr 2019 06:51:11 +0100 Subject: [PATCH 3/3] Fix use of SerialDelimiter value 128 This was allowing printable characters when set to 128, but also allowed all characters that are not 128. --- sonoff/sonoff.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonoff/sonoff.ino b/sonoff/sonoff.ino index 81e3efe28..c26bab267 100755 --- a/sonoff/sonoff.ino +++ b/sonoff/sonoff.ino @@ -2274,7 +2274,7 @@ void SerialInput(void) if (serial_in_byte || Settings.flag.mqtt_serial_raw) { // Any char between 1 and 127 or any char (0 - 255) if ((serial_in_byte_counter < INPUT_BUFFER_SIZE -1) && // Add char to string if it still fits and ... ((isprint(serial_in_byte) && (128 == Settings.serial_delimiter)) || // Any char between 32 and 127 - (serial_in_byte != Settings.serial_delimiter) || // Any char between 1 and 127 and not being delimiter + (serial_in_byte != Settings.serial_delimiter && (128 != Settings.serial_delimiter)) || // Any char between 1 and 127 and not being delimiter Settings.flag.mqtt_serial_raw)) { // Any char between 0 and 255 serial_in_buffer[serial_in_byte_counter++] = serial_in_byte; serial_polling_window = millis();