jeans/Tasmota
jeans/Tasmota
1
0
Fork 0
mirror of https://github.com/arendst/Tasmota.git synced 2025-07-25 19:56:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

CommandHandler() optimize and maybe security fix

Browse Source
This commit is contained in:
Jörg Schüler-Maroldt 2020-04-25 00:55:39 +02:00
parent 24eff9108b
commit 4c0a85ba0f
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tasmota/support_command.ino
View File

@ -204,13 +204,18 @@ void CommandHandler(char* topicBuf, char* dataBuf, uint32_t data_len)
if (type != nullptr) { if (type != nullptr) {
type++; type++;
uint32_t i; uint32_t i;
for (i = 0; i < strlen(type); i++) { int nLen; // strlen(type)
type[i] = toupper(type[i]); char *s = type;
for (nLen = 0; *s; s++, nLen++) {
*s=toupper(*s);
} }
i = nLen;
if (i > 0) { // may be 0
while (isdigit(type[i-1])) { while (isdigit(type[i-1])) {
i--; i--;
} }
if (i < strlen(type)) { }
if (i < nLen) {
index = atoi(type + i); index = atoi(type + i);
user_index = true; user_index = true;
} }