From 547791058aa805b1b1c42e8be0f2654b5a8e4853 Mon Sep 17 00:00:00 2001 From: Theo Arends <11044339+arendst@users.noreply.github.com> Date: Mon, 30 Aug 2021 11:09:10 +0200 Subject: [PATCH] Remove redundant code --- tasmota/xdrv_45_shelly_dimmer.ino | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tasmota/xdrv_45_shelly_dimmer.ino b/tasmota/xdrv_45_shelly_dimmer.ino index 32449faa8..aa8534cf8 100644 --- a/tasmota/xdrv_45_shelly_dimmer.ino +++ b/tasmota/xdrv_45_shelly_dimmer.ino @@ -534,18 +534,22 @@ bool ShdPacketProcess(void) Energy.active_power[0] = wattage; Energy.voltage[0] = voltage; Energy.current[0] = current; +/* + // This is duplicated code as it is already services by the Energy driver (xdrv_03_energy.ino) Energy.apparent_power[0] = voltage * current; + if ((voltage * current) > wattage) Energy.reactive_power[0] = sqrtf((voltage * current) * (voltage * current) - wattage * wattage); else Energy.reactive_power[0] = 0; + if (wattage > (voltage * current)) Energy.power_factor[0] = 1; else if ((voltage * current) == 0) Energy.power_factor[0] = 0; else Energy.power_factor[0] = wattage / (voltage * current); - +*/ if (Shd.last_power_check > 10 && Energy.active_power[0] > 0) { float kWhused = (float)Energy.active_power[0] * (Rtc.utc_time - Shd.last_power_check) / 36;