From 2167c642a6a118d35a33d4c7b949228fa79eb058 Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 17:03:26 -0300 Subject: [PATCH 01/10] Update Spanish Translation --- sonoff/language/es-AR.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonoff/language/es-AR.h b/sonoff/language/es-AR.h index 64f8fd677..a0f80b73f 100644 --- a/sonoff/language/es-AR.h +++ b/sonoff/language/es-AR.h @@ -102,7 +102,7 @@ #define D_IMMEDIATE "inmediato" // Button immediate #define D_INDEX "Índice" #define D_INFO "Información" -#define D_INFRARED "Infrared" +#define D_INFRARED "Infrarrojo" #define D_INITIALIZED "Inicializado" #define D_IP_ADDRESS "Dirección IP" #define D_LIGHT "Luz" From 162a3cc2ce096bc2d7f5f92f20779ad07181ba0a Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 20:31:34 -0300 Subject: [PATCH 02/10] Create templates for Bugs, Request and Troubleshooting As an attempt to help on the issues resolutions, a clasification is needed also providing some steps for the descriptions required. --- .github/ISSUE_TEMPLATE/Bug_report.md | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/Bug_report.md diff --git a/.github/ISSUE_TEMPLATE/Bug_report.md b/.github/ISSUE_TEMPLATE/Bug_report.md new file mode 100644 index 000000000..39c8f0f9d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/Bug_report.md @@ -0,0 +1,27 @@ +--- +name: Bug report +about: Create a report to help us improve + +--- + +**Describe the bug** + +A clear and concise description of what the bug is. + +Also, make sure these boxes are checked [x] before submitting your issue - Thank you! + +- [ ] Searched the problem in issues and in the wiki +- [ ] Hardware used : +- [ ] Provide the output of command ``status 0`` : + +**To Reproduce** +Steps to reproduce the behavior: + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**Additional context** +Add any other context about the problem here. From ef0f05025fa3f8fc26d8db820db38df5c8f0033c Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 20:32:52 -0300 Subject: [PATCH 03/10] Create Custom.md --- .github/ISSUE_TEMPLATE/Custom.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/Custom.md diff --git a/.github/ISSUE_TEMPLATE/Custom.md b/.github/ISSUE_TEMPLATE/Custom.md new file mode 100644 index 000000000..91e3ef143 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/Custom.md @@ -0,0 +1,16 @@ +--- +name: Troubleshooting +about: Troubleshooting Help + +--- + +Make sure these boxes are checked [x] before submitting your issue - Thank you! + +- [ ] Searched the problem in issues (https://github.com/arendst/Sonoff-Tasmota/issues) +- [ ] Searched the problem in the wiki (https://github.com/arendst/Sonoff-Tasmota/wiki/Troubleshooting) +- [ ] Searched the problem in the forum (https://forum.digital-pig.com/) +- [ ] Searched the problem in the discussion group (https://groups.google.com/d/forum/sonoffusers) +- [ ] Hardware used : +- [ ] Provide the output of command ``status 0`` : + +**Please, remember to close the issue when the problem has been addressed.** From fa4e37b09b94dc5eae8597fa958f06c43828af5e Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 20:33:14 -0300 Subject: [PATCH 04/10] Create Feature_request.md --- .github/ISSUE_TEMPLATE/Feature_request.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/Feature_request.md diff --git a/.github/ISSUE_TEMPLATE/Feature_request.md b/.github/ISSUE_TEMPLATE/Feature_request.md new file mode 100644 index 000000000..d10bdb778 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/Feature_request.md @@ -0,0 +1,18 @@ +--- +name: Feature request +about: Suggest an idea for this project + +--- +**Have you look for this feature in other issues and in the wiki?** + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 1e9b985e6b2fd911973e631b933fac822a5ab706 Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 20:33:35 -0300 Subject: [PATCH 05/10] Delete ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md deleted file mode 100644 index cb8cd1d03..000000000 --- a/.github/ISSUE_TEMPLATE.md +++ /dev/null @@ -1,6 +0,0 @@ -Make sure these boxes are checked before submitting your issue - Thank you! - -- [ ] What hardware you are using -- [ ] Provide the output of command ``status 0`` -- [ ] If you have a stack dump decode it: https://github.com/esp8266/Arduino/blob/master/doc/Troubleshooting/stack_dump.rst -- [ ] For better debug messages: https://github.com/esp8266/Arduino/blob/master/doc/Troubleshooting/debugging.rst From 043ce1a51c61c329080fda00cadaf75f21909f4e Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 20:34:35 -0300 Subject: [PATCH 06/10] Troubleshooting Template --- .github/ISSUE_TEMPLATE/Custom.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/Custom.md b/.github/ISSUE_TEMPLATE/Custom.md index 91e3ef143..e4a0eb8df 100644 --- a/.github/ISSUE_TEMPLATE/Custom.md +++ b/.github/ISSUE_TEMPLATE/Custom.md @@ -1,6 +1,6 @@ --- name: Troubleshooting -about: Troubleshooting Help +about: Users Troubleshooting Help --- From 2cb713f5c65b05d9ae44cdeb9c3c67cc66063d1f Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 21:03:26 -0300 Subject: [PATCH 07/10] Update Feature_request.md --- .github/ISSUE_TEMPLATE/Feature_request.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/Feature_request.md b/.github/ISSUE_TEMPLATE/Feature_request.md index d10bdb778..8a0895c8e 100644 --- a/.github/ISSUE_TEMPLATE/Feature_request.md +++ b/.github/ISSUE_TEMPLATE/Feature_request.md @@ -16,3 +16,5 @@ A clear and concise description of any alternative solutions or features you've **Additional context** Add any other context or screenshots about the feature request here. + +**(Please, remember to close the issue when the problem has been addressed)** From da89d75f8bb1d4f3c9aa62037ce1cbfffad78e07 Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 21:03:37 -0300 Subject: [PATCH 08/10] Update Custom.md --- .github/ISSUE_TEMPLATE/Custom.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/Custom.md b/.github/ISSUE_TEMPLATE/Custom.md index e4a0eb8df..62e47446d 100644 --- a/.github/ISSUE_TEMPLATE/Custom.md +++ b/.github/ISSUE_TEMPLATE/Custom.md @@ -13,4 +13,4 @@ Make sure these boxes are checked [x] before submitting your issue - Thank you! - [ ] Hardware used : - [ ] Provide the output of command ``status 0`` : -**Please, remember to close the issue when the problem has been addressed.** +**(Please, remember to close the issue when the problem has been addressed)** From b83543d209c0c188a7abedb3a86d2a6593be38d2 Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sat, 12 May 2018 21:03:46 -0300 Subject: [PATCH 09/10] Update Bug_report.md --- .github/ISSUE_TEMPLATE/Bug_report.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/Bug_report.md b/.github/ISSUE_TEMPLATE/Bug_report.md index 39c8f0f9d..7dc1e3499 100644 --- a/.github/ISSUE_TEMPLATE/Bug_report.md +++ b/.github/ISSUE_TEMPLATE/Bug_report.md @@ -25,3 +25,5 @@ If applicable, add screenshots to help explain your problem. **Additional context** Add any other context about the problem here. + +**(Please, remember to close the issue when the problem has been addressed)** From 0cfc921461ef3b6674c7f3cd786342419edc9d2a Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Sun, 13 May 2018 00:12:02 -0300 Subject: [PATCH 10/10] Fix DST and STD times for Southern Hemisphere Fix issue #2684 DST and STD times for Southern Hemisphere --- sonoff/support.ino | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/sonoff/support.ino b/sonoff/support.ino index e56d7e540..84760e92b 100644 --- a/sonoff/support.ino +++ b/sonoff/support.ino @@ -1389,17 +1389,22 @@ void RtcSecond() if (local_time > 1451602800) { // 2016-01-01 int32_t time_offset = Settings.timezone * SECS_PER_HOUR; if (99 == Settings.timezone) { + dstoffset = DaylightSavingTime.offset * SECS_PER_MIN; + stdoffset = StandardTime.offset * SECS_PER_MIN; if (DaylightSavingTime.hemis) { - dstoffset = StandardTime.offset * SECS_PER_MIN; // Southern hemisphere - stdoffset = DaylightSavingTime.offset * SECS_PER_MIN; + // Southern hemisphere + if ((utc_time >= (standard_time - dstoffset)) && (utc_time < (daylight_saving_time - stdoffset))) { + time_offset = stdoffset; // Standard Time + } else { + time_offset = dstoffset; // Daylight Saving Time + } } else { - dstoffset = DaylightSavingTime.offset * SECS_PER_MIN; // Northern hemisphere - stdoffset = StandardTime.offset * SECS_PER_MIN; - } - if ((utc_time >= (daylight_saving_time - stdoffset)) && (utc_time < (standard_time - dstoffset))) { - time_offset = dstoffset; // Daylight Saving Time - } else { - time_offset = stdoffset; // Standard Time + // Northern hemisphere + if ((utc_time >= (daylight_saving_time - stdoffset)) && (utc_time < (standard_time - dstoffset))) { + time_offset = dstoffset; // Daylight Saving Time + } else { + time_offset = stdoffset; // Standard Time + } } } local_time += time_offset;