From 7d055b22718b48b713f29bc4e5cbf025a591ff07 Mon Sep 17 00:00:00 2001 From: RevK Date: Sat, 13 Apr 2019 06:51:11 +0100 Subject: [PATCH] Fix use of SerialDelimiter value 128 This was allowing printable characters when set to 128, but also allowed all characters that are not 128. --- sonoff/sonoff.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonoff/sonoff.ino b/sonoff/sonoff.ino index 81e3efe28..c26bab267 100755 --- a/sonoff/sonoff.ino +++ b/sonoff/sonoff.ino @@ -2274,7 +2274,7 @@ void SerialInput(void) if (serial_in_byte || Settings.flag.mqtt_serial_raw) { // Any char between 1 and 127 or any char (0 - 255) if ((serial_in_byte_counter < INPUT_BUFFER_SIZE -1) && // Add char to string if it still fits and ... ((isprint(serial_in_byte) && (128 == Settings.serial_delimiter)) || // Any char between 32 and 127 - (serial_in_byte != Settings.serial_delimiter) || // Any char between 1 and 127 and not being delimiter + (serial_in_byte != Settings.serial_delimiter && (128 != Settings.serial_delimiter)) || // Any char between 1 and 127 and not being delimiter Settings.flag.mqtt_serial_raw)) { // Any char between 0 and 255 serial_in_buffer[serial_in_byte_counter++] = serial_in_byte; serial_polling_window = millis();