From 846f4d01781e02a34ffa4c40b9ffbf96c8e754bb Mon Sep 17 00:00:00 2001 From: Theo Arends Date: Mon, 12 Mar 2018 11:04:38 +0100 Subject: [PATCH] v5.12.0e - Better fix MAX31850 higher temperatures 5.12.0e * Fix MAX31850 higher temperatures (#1269) --- sonoff/xsns_05_ds18x20.ino | 6 +----- sonoff/xsns_05_ds18x20_legacy.ino | 8 ++------ 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/sonoff/xsns_05_ds18x20.ino b/sonoff/xsns_05_ds18x20.ino index 545b27e72..23dc4482e 100644 --- a/sonoff/xsns_05_ds18x20.ino +++ b/sonoff/xsns_05_ds18x20.ino @@ -336,11 +336,7 @@ boolean Ds18x20Read(uint8_t sensor, float &t) break; case MAX31850_CHIPID: temp14 = (data[1] << 8) + (data[0] & 0xFC); - if (temp14 < 0) { - temp14 = (~temp14) +1; - sign = -1; - } - t = ConvertTemp(sign * temp14 * 0.0625); // Divide by 16 + t = ConvertTemp(temp14 * 0.0625); // Divide by 16 break; } } diff --git a/sonoff/xsns_05_ds18x20_legacy.ino b/sonoff/xsns_05_ds18x20_legacy.ino index d352c064c..085280ece 100644 --- a/sonoff/xsns_05_ds18x20_legacy.ino +++ b/sonoff/xsns_05_ds18x20_legacy.ino @@ -140,12 +140,8 @@ boolean Ds18x20Read(uint8_t sensor, float &t) t = ConvertTemp(sign * temp12 * 0.0625); // Divide by 16 break; case MAX31850_CHIPID: - temp14 = (data[1] << 8) + (data[0] & 0xFC); - if (temp14 < 0) { - temp14 = (~temp14) +1; - sign = -1; - } - t = ConvertTemp(sign * temp14 * 0.0625); // Divide by 16 + temp14 = (data[1] << 8) + (data[0] & 0xFC); + t = ConvertTemp(temp14 * 0.0625); // Divide by 16 break; } }