From abe6b4e4f427dd200cbae3a4db86d56057bff857 Mon Sep 17 00:00:00 2001 From: Adrian Scillato <35405447+ascillato@users.noreply.github.com> Date: Mon, 4 May 2020 11:25:46 -0300 Subject: [PATCH] PR Template. Move the CI Pass request to a Note As the CI Test is done after the PR is submitted, a checkbox for "The code change must pass CI tests" is always left unchecked. It should be better to just add a note that the proposed PR is going to be tested and that the CI Tests must be passed in order to merge the PR. Any CI Test error should be addressed by the author of the PR, before merging. --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index dade0687c..d8bb487bd 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,5 +8,6 @@ - [ ] Only one feature/fix was added per PR. - [ ] The code change is tested and works on core ESP8266 V.2.7.0 - [ ] The code change is tested and works on core ESP32 V.1.12.0 - - [ ] The code change pass CI tests. **Your PR cannot be merged unless tests pass** - [ ] I accept the [CLA](https://github.com/arendst/Tasmota/blob/development/CONTRIBUTING.md#contributor-license-agreement-cla). + +_NOTE: The code change must pass CI tests. **Your PR cannot be merged unless tests pass**_