jeans/Tasmota
jeans/Tasmota
1
0
Fork 0
mirror of https://github.com/arendst/Tasmota.git synced 2025-07-23 18:56:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix DS18S20 temp calculation

Browse Source 
Fix DS18S20 temp calculation  (#8777)
This commit is contained in:
Theo Arends 2020-07-12 15:24:42 +02:00
parent 8df6184007
commit e3fd1b7850
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tasmota/xsns_05_ds18x20.ino
View File

@ -375,12 +375,19 @@ bool Ds18x20Read(uint8_t sensor)
if (OneWireCrc8(data)) { if (OneWireCrc8(data)) {
switch(ds18x20_sensor[index].address[0]) { switch(ds18x20_sensor[index].address[0]) {
case DS18S20_CHIPID: { case DS18S20_CHIPID: {
/*
if (data[1] > 0x80) { if (data[1] > 0x80) {
data[0] = (~data[0]) +1; data[0] = (~data[0]) +1;
sign = -1; // App-Note fix possible sign error sign = -1; // App-Note fix possible sign error
} }
float temp9 = (float)(data[0] >> 1) * sign; float temp9 = (float)(data[0] >> 1) * sign;
ds18x20_sensor[index].temperature = ConvertTemp((temp9 - 0.25) + ((16.0 - data[6]) / 16.0)); ds18x20_sensor[index].temperature = ConvertTemp((temp9 - 0.25) + ((16.0 - data[6]) / 16.0));
Replaced by below based on issue #8777
*/
int16_t tempS = (((data[1] << 8) | (data[0] & 0xFE)) << 3) | ((0x10 - data[6]) & 0x0F);
ds18x20_sensor[index].temperature = ConvertTemp(tempS * 0.0625 - 0.250);
ds18x20_sensor[index].valid = SENSOR_MAX_MISS; ds18x20_sensor[index].valid = SENSOR_MAX_MISS;
return true; return true;
} }