From f42cb555c3d14f3aaf78b5cb8879b899375007da Mon Sep 17 00:00:00 2001 From: s-hadinger <49731213+s-hadinger@users.noreply.github.com> Date: Thu, 9 Jan 2025 19:16:49 +0100 Subject: [PATCH] 'Pixels' has backwards compatible arguments fixing #22755 (#22791) * 'Pixels' has backwards compatible arguments fixing #22755 * Fix fallback height --- CHANGELOG.md | 1 + tasmota/tasmota_xlgt_light/xlgt_01_ws2812_esp32.ino | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5714f5fb7..cbf92f4b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file. ### Changed - GPIOViewer from v1.5.8 to v1.5.9 (No functional change) +- `Pixels` has backwards compatible arguments fixing #22755 ### Fixed - Shutter discovery message regression from v14.4.1 (#22730) diff --git a/tasmota/tasmota_xlgt_light/xlgt_01_ws2812_esp32.ino b/tasmota/tasmota_xlgt_light/xlgt_01_ws2812_esp32.ino index 84319cd0d..f2ed0d10e 100644 --- a/tasmota/tasmota_xlgt_light/xlgt_01_ws2812_esp32.ino +++ b/tasmota/tasmota_xlgt_light/xlgt_01_ws2812_esp32.ino @@ -791,15 +791,15 @@ void CmndLed(void) void CmndPixels(void) { - uint32_t parm[4] = { Settings->light_pixels, Settings->light_pixels_reverse, - (uint32_t) Settings->light_pixels_height_1 + 1, Settings->light_pixels_alternate }; + uint32_t parm[4] = { Settings->light_pixels, 0 /* reverse = 0 */, + 0 /* height = 1 (minus 1) */, 0 /* alternate = 0 */ }; if (ParseParameters(4, parm) > 0) { if ((parm[0] > 0) && (parm[0] <= WS2812_MAX_LEDS)) { Ws2812Clear(); // Clear all known pixels Ws2812CanShowWait(); Settings->light_pixels = parm[0]; Settings->light_pixels_reverse = parm[1]; - Settings->light_pixels_height_1 = (parm[2] > 0) ? parm[2] - 1 : 1; + Settings->light_pixels_height_1 = (parm[2] > 0) ? parm[2] - 1 : 0; Settings->light_pixels_alternate = parm[3]; Ws2812ChangePixelCount(); Light.update = true;