From 5ac8ba9bae80688ab9c9151e8775447d8e86cbf1 Mon Sep 17 00:00:00 2001
From: Wouter Gritter <wouter@gritter.me>
Date: Thu, 21 Nov 2024 12:02:55 +0100
Subject: [PATCH] Revert "Introduce printSetInputMaxlength to properly set an
 inputs maxlength variable"

This reverts commit 49fb16e2c6528ddc98cccc352cc8f0d4a5f62a13.
---
 wled00/fcn_declare.h | 1 -
 wled00/util.cpp      | 4 ----
 wled00/xml.cpp       | 5 ++---
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/wled00/fcn_declare.h b/wled00/fcn_declare.h
index 91176160f..1855a8b63 100644
--- a/wled00/fcn_declare.h
+++ b/wled00/fcn_declare.h
@@ -380,7 +380,6 @@ size_t printSetFormValue(Print& settingsScript, const char* key, int val);
 size_t printSetFormValue(Print& settingsScript, const char* key, const char* val);
 size_t printSetFormIndex(Print& settingsScript, const char* key, int index);
 size_t printSetClassElementHTML(Print& settingsScript, const char* key, const int index, const char* val);
-size_t printSetInputMaxLength(Print& settingsScript, const char* key, int val);
 void prepareHostname(char* hostname);
 bool isAsterisksOnly(const char* str, byte maxLen);
 bool requestJSONBufferLock(uint8_t module=255);
diff --git a/wled00/util.cpp b/wled00/util.cpp
index 1c1282eda..0b78a4646 100644
--- a/wled00/util.cpp
+++ b/wled00/util.cpp
@@ -109,10 +109,6 @@ size_t printSetClassElementHTML(Print& settingsScript, const char* key, const in
   return settingsScript.printf_P(PSTR("d.getElementsByClassName(\"%s\")[%d].innerHTML=\"%s\";"), key, index, val);
 }
 
-size_t printSetInputMaxLength(Print& settingsScript, const char* key, int val) {
-  return settingsScript.printf_P(PSTR("d.Sf.%s.setAttribute(\"maxlength\", %d);"),key,val);
-}
-
 
 
 void prepareHostname(char* hostname)
diff --git a/wled00/xml.cpp b/wled00/xml.cpp
index 6f837a9b6..dc2673271 100644
--- a/wled00/xml.cpp
+++ b/wled00/xml.cpp
@@ -465,9 +465,8 @@ void getSettingsJS(byte subPage, Print& settingsScript)
     printSetFormValue(settingsScript,PSTR("MG"),mqttGroupTopic);
     printSetFormCheckbox(settingsScript,PSTR("BM"),buttonPublishMqtt);
     printSetFormCheckbox(settingsScript,PSTR("RT"),retainMqttMsg);
-    printSetInputMaxLength(settingsScript, PSTR("MD"), MQTT_MAX_TOPIC_LEN);
-    printSetInputMaxLength(settingsScript, PSTR("MG"), MQTT_MAX_TOPIC_LEN);
-    printSetInputMaxLength(settingsScript, PSTR("MS"), MQTT_MAX_SERVER_LEN);
+    settingsScript.printf_P(PSTR("d.Sf.MD.maxlength=%d;d.Sf.MG.maxlength=%d;d.Sf.MS.maxlength=%d;"),
+                  MQTT_MAX_TOPIC_LEN, MQTT_MAX_TOPIC_LEN, MQTT_MAX_SERVER_LEN);
     #else
     settingsScript.print(F("toggle('MQTT');"));    // hide MQTT settings
     #endif