diff --git a/usermods/Animated_Staircase/Animated_Staircase.h b/usermods/Animated_Staircase/Animated_Staircase.h index 3cf349ca5..427348d8e 100644 --- a/usermods/Animated_Staircase/Animated_Staircase.h +++ b/usermods/Animated_Staircase/Animated_Staircase.h @@ -114,8 +114,8 @@ class Animated_Staircase : public Usermod { // We may need to copy mode and colors from segment 0 to make sure // changes are propagated even when the config is changed during a wipe - // segments->mode = mainsegment.mode; - // segments->colors[0] = mainsegment.colors[0]; + // seg.setMode(mainsegment.mode); + // seg.setColor(0, mainsegment.colors[0]); } else { seg.setOption(SEG_OPTION_ON, false); } diff --git a/usermods/usermod_v2_rotary_encoder_ui_ALT/usermod_v2_rotary_encoder_ui_ALT.h b/usermods/usermod_v2_rotary_encoder_ui_ALT/usermod_v2_rotary_encoder_ui_ALT.h index 18435ca36..85ed7ff3c 100644 --- a/usermods/usermod_v2_rotary_encoder_ui_ALT/usermod_v2_rotary_encoder_ui_ALT.h +++ b/usermods/usermod_v2_rotary_encoder_ui_ALT/usermod_v2_rotary_encoder_ui_ALT.h @@ -531,11 +531,11 @@ public: for (byte i=0; i=0) unloadPlaylist(); - if (fx != seg.mode) { - seg.setMode(fx, elem[F("fxdef")]); - } + if (fx != seg.mode) seg.setMode(fx, elem[F("fxdef")]); } //getVal also supports inc/decrementing and random getVal(elem["sx"], &seg.speed); getVal(elem["ix"], &seg.intensity); + uint8_t pal = seg.palette; - if (getVal(elem["pal"], &pal, 1, strip.getPaletteCount())) { - seg.setPalette(pal); - } + if (getVal(elem["pal"], &pal, 1, strip.getPaletteCount())) seg.setPalette(pal); + getVal(elem["c1"], &seg.custom1); getVal(elem["c2"], &seg.custom2); uint8_t cust3 = seg.custom3; diff --git a/wled00/set.cpp b/wled00/set.cpp index daaf42715..235f8985e 100644 --- a/wled00/set.cpp +++ b/wled00/set.cpp @@ -888,17 +888,10 @@ bool handleSet(AsyncWebServerRequest *request, const String& req, bool apply) for (uint8_t i = 0; i < strip.getSegmentsNum(); i++) { Segment& seg = strip.getSegment(i); if (i != selectedSeg && (singleSegment || !seg.isActive() || !seg.isSelected())) continue; // skip non main segments if not applying to all - if (fxModeChanged) { - seg.startTransition(strip.getTransition()); - seg.mode = effectIn; - // TODO: we should load defaults here as well - } + if (fxModeChanged) seg.setMode(effectIn, req.indexOf(F("FXD="))>0); // apply defaults if FXD= is specified if (speedChanged) seg.speed = speedIn; if (intensityChanged) seg.intensity = intensityIn; - if (paletteChanged) { - if (strip.paletteBlend) seg.startTransition(strip.getTransition()); - seg.palette = paletteIn; - } + if (paletteChanged) seg.setPalette(paletteIn); } //set advanced overlay