From 9d8fdd0b20e407948b975d847cd1eecbd062f0cf Mon Sep 17 00:00:00 2001
From: Arne <arne@rnae.de>
Date: Fri, 18 Aug 2023 15:43:14 +0200
Subject: [PATCH] extract test for rdm identify into own method

---
 wled00/dmx_input.cpp | 15 +++++++++++----
 wled00/dmx_input.h   |  2 ++
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/wled00/dmx_input.cpp b/wled00/dmx_input.cpp
index a150fa780..d46e3bebb 100644
--- a/wled00/dmx_input.cpp
+++ b/wled00/dmx_input.cpp
@@ -103,11 +103,9 @@ void DMXInput::update()
         connected = true;
       }
 
-      uint8_t identify = 0;
-      const bool gotIdentify = rdm_get_identify_device(inputPortNum, &identify);
-      // gotIdentify should never be false because it is a default parameter in rdm but just in case we check for it anyway
-      if (identify && gotIdentify)
+      if (isIdentifyOn())
       {
+        DEBUG_PRINTLN("RDM Identify active");
         turnOnAllLeds();
       }
       else
@@ -162,4 +160,13 @@ void DMXInput::enable()
   }
 }
 
+bool DMXInput::isIdentifyOn() const
+{
+
+  uint8_t identify = 0;
+  const bool gotIdentify = rdm_get_identify_device(inputPortNum, &identify);
+  // gotIdentify should never be false because it is a default parameter in rdm
+  // but just in case we check for it anyway
+  return bool(identify) && gotIdentify;
+}
 #endif
\ No newline at end of file
diff --git a/wled00/dmx_input.h b/wled00/dmx_input.h
index b96077c1b..27425d0d4 100644
--- a/wled00/dmx_input.h
+++ b/wled00/dmx_input.h
@@ -17,6 +17,8 @@ public:
   void enable();
 
 private:
+  /// @return true if rdm identify is active
+  bool isIdentifyOn() const;
 
   /// overrides everything and turns on all leds
   void turnOnAllLeds();