From a2dce56809b14c59fb431bf118a3813ee5cfd695 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frank=20M=C3=B6hle?= <91616163+softhack007@users.noreply.github.com> Date: Fri, 10 Apr 2026 02:43:40 +0200 Subject: [PATCH] Update pull request expectations: approval needed to modify platformio.ini Clarify approval requirement for modifications to platformio.ini --- .github/copilot-instructions.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index c4d2c0b90..bf16a9ba5 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -130,6 +130,7 @@ Using AI-generated code can hide the source of the inspiration / knowledge / sou ### Pull Request Expectations - **No force-push on open PRs.** Once a pull request is open and being reviewed, do not force-push (`git push --force`) to the branch. Force-pushing rewrites history that reviewers may have already commented on, making it impossible to track incremental changes. Use regular commits or `git merge` to incorporate feedback; the branch will be squash-merged when it is accepted. +- **Modifications to ``platformio.ini`` MUST be approved explicitly by a *maintainer* or *WLED organisation member*. Modifications to the global build environment may break github action builds. Always flag them. - **Document your changes in the PR.** Every pull request should include a clear description of *what* changed and *why*. If the change affects user-visible behavior, describe the expected impact. Link to related issues where applicable. Provide screenshots to showcase new features. ### Supporting Reviews and Discussions