jeans/WLED
jeans/WLED
1
0
Fork 0
mirror of https://github.com/wled/WLED.git synced 2025-07-19 16:56:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

udp realtime - improve robustness against short packets (fix for #3672)

Browse Source 
when only two bytes were received in a packet, the "for" condition `packetsize -3` would underflow, leading to an infinite loop.
This commit is contained in:
Frank 2024-01-11 18:07:23 +01:00 committed by GitHub
parent a11cab0f88
commit a9eb7cb4fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wled00/udp.cpp
View File

@ -525,7 +525,7 @@ void handleNotifications()
if (realtimeOverride && !(realtimeMode && useMainSegmentOnly)) return; if (realtimeOverride && !(realtimeMode && useMainSegmentOnly)) return;
uint16_t totalLen = strip.getLengthTotal(); uint16_t totalLen = strip.getLengthTotal();
if (udpIn[0] == 1) //warls if ((udpIn[0] == 1) && (packetSize > 5)) //warls - avoiding infinite "for" loop (unsigned underflow)
{ {
for (size_t i = 2; i < packetSize -3; i += 4) for (size_t i = 2; i < packetSize -3; i += 4)
{ {
@ -540,7 +540,7 @@ void handleNotifications()
id++; if (id >= totalLen) break; id++; if (id >= totalLen) break;
} }
} else if (udpIn[0] == 3) //drgbw } else if ((udpIn[0] == 3) && (packetSize > 5)) //drgbw - avoiding infinite "for" loop (unsigned underflow)
{ {
uint16_t id = 0; uint16_t id = 0;
for (size_t i = 2; i < packetSize -3; i += 4) for (size_t i = 2; i < packetSize -3; i += 4)