From bd69c24231153912e97ff31be399dcedd34567a5 Mon Sep 17 00:00:00 2001
From: Maximilian Mewes <mewes.maximilian@gmx.de>
Date: Tue, 30 Apr 2024 14:54:53 +0200
Subject: [PATCH] intermediate update

---
 usermods/Battery/battery_defaults.h   | 1 +
 usermods/Battery/readme.md            | 5 +++++
 usermods/Battery/types/lion.h         | 3 +--
 usermods/Battery/types/lipo.h         | 3 +--
 usermods/Battery/types/unkown.h       | 3 +--
 usermods/Battery/usermod_v2_Battery.h | 6 ++----
 6 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/usermods/Battery/battery_defaults.h b/usermods/Battery/battery_defaults.h
index 6d0a95dc4..ea01e8620 100644
--- a/usermods/Battery/battery_defaults.h
+++ b/usermods/Battery/battery_defaults.h
@@ -111,6 +111,7 @@
   #define USERMOD_BATTERY_LOW_POWER_INDICATOR_DURATION 5
 #endif
 
+// battery types
 typedef enum
 {
   unknown=0,
diff --git a/usermods/Battery/readme.md b/usermods/Battery/readme.md
index 1ca229763..e82378084 100644
--- a/usermods/Battery/readme.md
+++ b/usermods/Battery/readme.md
@@ -86,6 +86,11 @@ Specification from:  [Molicel INR18650-M35A, 3500mAh 10A Lithium-ion battery, 3.
 
 ## 📝 Change Log
 
+2024-04-30
+
+- integrate factory pattern to make it easier to add other / custom battery types
+- update readme
+
 2023-01-04
 
 - basic support for LiPo rechargeable batteries ( `-D USERMOD_BATTERY_USE_LIPO`)
diff --git a/usermods/Battery/types/lion.h b/usermods/Battery/types/lion.h
index 0d2325386..b3641e263 100644
--- a/usermods/Battery/types/lion.h
+++ b/usermods/Battery/types/lion.h
@@ -13,8 +13,7 @@ class Lion : public Battery
     private:
 
     public:
-        Lion()
-        : Battery()
+        Lion() : Battery()
         {
             this->setMinVoltage(USERMOD_BATTERY_LION_MIN_VOLTAGE);
             this->setMaxVoltage(USERMOD_BATTERY_LION_MAX_VOLTAGE);
diff --git a/usermods/Battery/types/lipo.h b/usermods/Battery/types/lipo.h
index f65ab12c5..1deb6e7d3 100644
--- a/usermods/Battery/types/lipo.h
+++ b/usermods/Battery/types/lipo.h
@@ -13,8 +13,7 @@ class Lipo : public Battery
     private:
 
     public:
-        Lipo()
-        : Battery()
+        Lipo() : Battery()
         {
             this->setMinVoltage(USERMOD_BATTERY_LIPO_MIN_VOLTAGE);
             this->setMaxVoltage(USERMOD_BATTERY_LIPO_MAX_VOLTAGE);
diff --git a/usermods/Battery/types/unkown.h b/usermods/Battery/types/unkown.h
index edf220040..32a1bfe42 100644
--- a/usermods/Battery/types/unkown.h
+++ b/usermods/Battery/types/unkown.h
@@ -13,8 +13,7 @@ class Unkown : public Battery
     private:
 
     public:
-        Unkown()
-        : Battery()
+        Unkown() : Battery()
         {
             this->setMinVoltage(USERMOD_BATTERY_UNKOWN_MIN_VOLTAGE);
             this->setMaxVoltage(USERMOD_BATTERY_UNKOWN_MAX_VOLTAGE);
diff --git a/usermods/Battery/usermod_v2_Battery.h b/usermods/Battery/usermod_v2_Battery.h
index 9b980d557..a82a46667 100644
--- a/usermods/Battery/usermod_v2_Battery.h
+++ b/usermods/Battery/usermod_v2_Battery.h
@@ -9,9 +9,8 @@
 
 /*
  * Usermod by Maximilian Mewes
- * Mail: mewes.maximilian@gmx.de
- * GitHub: itCarl
- * Date: 25.12.2022
+ * E-mail: mewes.maximilian@gmx.de
+ * Created at: 25.12.2022
  * If you have any questions, please feel free to contact me.
  */
 class UsermodBattery : public Usermod 
@@ -140,7 +139,6 @@ class UsermodBattery : public Usermod
         }
       #else //ESP8266 boards have only one analog input pin A0
         pinMode(batteryPin, INPUT);
-        // voltage = readVoltage();
       #endif
 
       // plug in the right battery type