Error message if upload is not possible (#1353)

This commit is contained in:
Francesco Spissu 2022-08-26 11:24:03 +02:00 committed by GitHub
parent fc9107c084
commit 0c22884729
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 5 deletions

View File

@ -222,6 +222,12 @@ export abstract class CoreServiceContribution extends SketchContribution {
} catch {} } catch {}
} }
if (message) { if (message) {
if (message.includes('Missing FQBN (Fully Qualified Board Name)')) {
message = nls.localize(
'arduino/coreContribution/noBoardSelected',
'No board selected. Please select your Arduino board from the Tools > Board menu.'
);
}
const copyAction = nls.localize( const copyAction = nls.localize(
'arduino/coreContribution/copyError', 'arduino/coreContribution/copyError',
'Copy error messages' 'Copy error messages'

View File

@ -61,10 +61,11 @@ export class UploadSketch extends CoreServiceContribution {
registry.registerCommand(UploadSketch.Commands.UPLOAD_SKETCH, { registry.registerCommand(UploadSketch.Commands.UPLOAD_SKETCH, {
execute: async () => { execute: async () => {
const key = this.selectedFqbnAddress(); const key = this.selectedFqbnAddress();
if (!key) { if (
return; this.boardRequiresUserFields &&
} key &&
if (this.boardRequiresUserFields && !this.cachedUserFields.has(key)) { !this.cachedUserFields.has(key)
) {
// Deep clone the array of board fields to avoid editing the cached ones // Deep clone the array of board fields to avoid editing the cached ones
this.userFieldsDialog.value = ( this.userFieldsDialog.value = (
await this.boardsServiceProvider.selectedBoardUserFields() await this.boardsServiceProvider.selectedBoardUserFields()

View File

@ -132,7 +132,8 @@
"replaceTitle": "Replace" "replaceTitle": "Replace"
}, },
"coreContribution": { "coreContribution": {
"copyError": "Copy error messages" "copyError": "Copy error messages",
"noBoardSelected": "No board selected. Please select your Arduino board from the Tools > Board menu."
}, },
"daemon": { "daemon": {
"restart": "Restart Daemon", "restart": "Restart Daemon",