jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-11-07 17:38:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

ATL-879: Avoid reopening the same sketch.

Browse Source 
Instead of reopening it, focus the existing window.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
This commit is contained in:
Akos Kitta
2021-02-03 14:14:34 +01:00
committed by Akos Kitta
parent 96f0722d56
commit 23877f162c
3 changed files with 38 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
View File

@@ -13,7 +13,7 @@ import { SplashServiceImpl } from '../splash/splash-service-impl';
@injectable()
export class ElectronMainApplication extends TheiaElectronMainApplication {
protected windows: BrowserWindow[] = [];
protected _windows: BrowserWindow[] = [];
@inject(SplashServiceImpl)
protected readonly splashService: SplashServiceImpl;
@@ -34,7 +34,7 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
async createWindow(asyncOptions: MaybePromise<TheiaBrowserWindowOptions> = this.getDefaultBrowserWindowOptions()): Promise<BrowserWindow> {
const options = await asyncOptions;
let electronWindow: BrowserWindow | undefined;
if (this.windows.length) {
if (this._windows.length) {
electronWindow = new BrowserWindow(options);
} else {
const { bounds } = screen.getDisplayNearestPoint(screen.getCursorScreenPoint());
@@ -63,14 +63,14 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
splashScreenOpts
}, this.splashService.onCloseRequested);
}
this.windows.push(electronWindow);
this._windows.push(electronWindow);
electronWindow.on('closed', () => {
if (electronWindow) {
const index = this.windows.indexOf(electronWindow);
const index = this._windows.indexOf(electronWindow);
if (index === -1) {
console.warn(`Could not dispose browser window: '${electronWindow.title}'.`);
} else {
this.windows.splice(index, 1);
this._windows.splice(index, 1);
electronWindow = undefined;
}
}
@@ -148,4 +148,8 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
}
}
get windows(): BrowserWindow[] {
return this._windows.slice();
}
}