mirror of
https://github.com/arduino/arduino-ide.git
synced 2025-11-10 10:58:33 +00:00
Prevent layout shift on hover in libs/board manager (#1568)
This commit is contained in:
@@ -14,37 +14,21 @@ export class ComponentListItem<
|
||||
)[0];
|
||||
this.state = {
|
||||
selectedVersion: version,
|
||||
focus: false,
|
||||
versionUpdate: false,
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
override componentDidUpdate(
|
||||
prevProps: ComponentListItem.Props<T>,
|
||||
prevState: ComponentListItem.State
|
||||
): void {
|
||||
if (this.state.focus !== prevState.focus) {
|
||||
this.props.onFocusDidChange();
|
||||
}
|
||||
}
|
||||
|
||||
override render(): React.ReactNode {
|
||||
const { item, itemRenderer } = this.props;
|
||||
return (
|
||||
<div
|
||||
onMouseEnter={() => this.setState({ focus: true })}
|
||||
onMouseLeave={() => {
|
||||
if (!this.state.versionUpdate) this.setState({ focus: false });
|
||||
}}
|
||||
>
|
||||
<>
|
||||
{itemRenderer.renderItem(
|
||||
Object.assign(this.state, { item }),
|
||||
this.install.bind(this),
|
||||
this.uninstall.bind(this),
|
||||
this.onVersionChange.bind(this)
|
||||
)}
|
||||
</div>
|
||||
</>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -55,7 +39,6 @@ export class ComponentListItem<
|
||||
)[0];
|
||||
this.setState({
|
||||
selectedVersion: version,
|
||||
versionUpdate: false,
|
||||
});
|
||||
try {
|
||||
await this.props.install(item, toInstall);
|
||||
@@ -71,7 +54,7 @@ export class ComponentListItem<
|
||||
}
|
||||
|
||||
private onVersionChange(version: Installable.Version): void {
|
||||
this.setState({ selectedVersion: version, versionUpdate: true });
|
||||
this.setState({ selectedVersion: version });
|
||||
}
|
||||
}
|
||||
|
||||
@@ -81,12 +64,9 @@ export namespace ComponentListItem {
|
||||
readonly install: (item: T, version?: Installable.Version) => Promise<void>;
|
||||
readonly uninstall: (item: T) => Promise<void>;
|
||||
readonly itemRenderer: ListItemRenderer<T>;
|
||||
readonly onFocusDidChange: () => void;
|
||||
}
|
||||
|
||||
export interface State {
|
||||
selectedVersion?: Installable.Version;
|
||||
focus: boolean;
|
||||
versionUpdate: boolean;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user