jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-06-08 21:26:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: let the upload run when no board is selected

Browse Source 
IDE2 must not disable the upload from the UI when no board is selected.
Otherwise, IDE2 does not receive the `no FQBN` error from
the CLI and cannot cannot
suggest selecting a board via the `Tools` > `Board` menu.

Closes arduino/arduino-ide#1714

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
Akos Kitta 2024-02-23 15:31:46 +01:00
parent aa9b10d68e
commit 3c5c014d45
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arduino-ide-extension/src/browser/contributions/user-fields.ts
View File

@ -74,7 +74,9 @@ export class UserFields extends Contribution {
async checkUserFieldsDialog(forceOpen = false): Promise<boolean> { async checkUserFieldsDialog(forceOpen = false): Promise<boolean> {
const key = this.selectedFqbnAddress(); const key = this.selectedFqbnAddress();
if (!key) { if (!key) {
return false; // Let the upload continue without an FQBN and the CLI fail instead of disabling the upload from IDE.
// https://github.com/arduino/arduino-ide/issues/1714
return true;
} }
/* /*
If the board requires to be configured with user fields, we want If the board requires to be configured with user fields, we want