Incorporated review feedback and moved to QuickPickService

This commit is contained in:
Christian Weichel
2019-05-08 13:32:39 +02:00
parent be20365a6b
commit 43ab17fd34
8 changed files with 30 additions and 118 deletions

View File

@@ -13,6 +13,7 @@ import { CoreService } from '../common/protocol/core-service';
import { WorkspaceServiceExt } from './workspace-service-ext';
import { ToolOutputServiceClient } from '../common/protocol/tool-output-service';
import { ConfirmDialog } from '@theia/core/lib/browser';
import { QuickPickService } from '@theia/core/lib/common/quick-pick-service';
@injectable()
@@ -33,6 +34,9 @@ export class ArduinoFrontendContribution extends DefaultFrontendApplicationContr
@inject(ToolOutputServiceClient)
protected readonly toolOutputServiceClient: ToolOutputServiceClient;
@inject(QuickPickService)
protected readonly quickPickService: QuickPickService;
@postConstruct()
protected async init(): Promise<void> {
// This is a hack. Otherwise, the backend services won't bind.
@@ -56,7 +60,7 @@ export class ArduinoFrontendContribution extends DefaultFrontendApplicationContr
});
registry.registerItem({
id: ConnectedBoards.TOOLBAR_ID,
render: () => <ConnectedBoards boardsService={this.boardService}/>,
render: () => <ConnectedBoards boardsService={this.boardService} quickPickService={this.quickPickService} />,
isVisible: widget => this.isArduinoEditor(widget)
})
}