jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-06-21 11:36:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: relaxed saveAll if no Internet connection

Browse Source 
The previous logic has incorrectly bailed the save when there is no
Internet connection. The corrected logic disallows saving files if there
is no connection between the frontend and the backend.

Ref: cff2c956845e04d320231e8a924d1a47ad016af7
Closes 

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
Akos Kitta 2023-05-30 10:59:23 +02:00 committed by Akos Kitta
parent db0049d635
commit 4af488b05e
1 changed files with 5 additions and 9 deletions

14
arduino-ide-extension/src/browser/theia/core/application-shell.ts

@ -8,13 +8,10 @@ import {
TabBar, TabBar,
Widget, Widget,
} from '@theia/core/lib/browser'; } from '@theia/core/lib/browser';
import {
ConnectionStatus,
ConnectionStatusService,
} from '@theia/core/lib/browser/connection-status-service';
import { nls } from '@theia/core/lib/common/nls'; import { nls } from '@theia/core/lib/common/nls';
import { MessageService } from '@theia/core/lib/common/message-service'; import { MessageService } from '@theia/core/lib/common/message-service';
import { inject, injectable } from '@theia/core/shared/inversify'; import { inject, injectable } from '@theia/core/shared/inversify';
import { ApplicationConnectionStatusContribution } from './connection-status-service';
import { ToolbarAwareTabBar } from './tab-bars'; import { ToolbarAwareTabBar } from './tab-bars';
@injectable() @injectable()
@ -22,8 +19,8 @@ export class ApplicationShell extends TheiaApplicationShell {
@inject(MessageService) @inject(MessageService)
private readonly messageService: MessageService; private readonly messageService: MessageService;
@inject(ConnectionStatusService) @inject(ApplicationConnectionStatusContribution)
private readonly connectionStatusService: ConnectionStatusService; private readonly connectionStatusService: ApplicationConnectionStatusContribution;
override async addWidget( override async addWidget(
widget: Widget, widget: Widget,
@ -64,9 +61,8 @@ export class ApplicationShell extends TheiaApplicationShell {
} }
override async saveAll(options?: SaveOptions): Promise<void> { override async saveAll(options?: SaveOptions): Promise<void> {
if ( // When there is no connection between the IDE2 frontend and backend.
this.connectionStatusService.currentStatus === ConnectionStatus.OFFLINE if (this.connectionStatusService.offlineStatus === 'backend') {
) {
this.messageService.error( this.messageService.error(
nls.localize( nls.localize(
'theia/core/couldNotSave', 'theia/core/couldNotSave',