From 52804a5b522771909515635a4d6cd8fc0ea1e86d Mon Sep 17 00:00:00 2001
From: per1234 <accounts@perglass.com>
Date: Sat, 20 Aug 2022 20:24:11 -0700
Subject: [PATCH] Add missing i18n for UI strings

The text of the Arduino IDE user interface has been localized to 12 languages.

Before localization can be accomplished, internationalization must be done in the application's code base:

- Set up infrastructure to export localization data
- Pass all target strings to that infrastructure

While the first of these tasks is completed, the second was not completed for several strings which are part of the user
interface.

Those outstanding strings are hereby internationalized and will be made available for localization.
---
 .../src/browser/boards/boards-config.tsx                 | 9 +++++++--
 .../dialogs/user-fields/user-fields-component.tsx        | 6 +++++-
 arduino-ide-extension/src/node/boards-service-impl.ts    | 6 +++++-
 i18n/en.json                                             | 4 ++++
 4 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/arduino-ide-extension/src/browser/boards/boards-config.tsx b/arduino-ide-extension/src/browser/boards/boards-config.tsx
index c72ba764..3e55b2b0 100644
--- a/arduino-ide-extension/src/browser/boards/boards-config.tsx
+++ b/arduino-ide-extension/src/browser/boards/boards-config.tsx
@@ -306,7 +306,10 @@ export class BoardsConfig extends React.Component<
             type="search"
             value={query}
             className="theia-input"
-            placeholder="SEARCH BOARD"
+            placeholder={nls.localize(
+              'arduino/board/searchBoard',
+              'SEARCH BOARD'
+            )}
             onChange={this.updateBoards}
             ref={this.focusNodeSet}
           />
@@ -344,7 +347,9 @@ export class BoardsConfig extends React.Component<
       });
     }
     return !ports.length ? (
-      <div className="loading noselect">No ports discovered</div>
+      <div className="loading noselect">
+        {nls.localize('arduino/board/noPortsDiscovered', 'No ports discovered')}
+      </div>
     ) : (
       <div className="ports list">
         {ports.map((port) => (
diff --git a/arduino-ide-extension/src/browser/dialogs/user-fields/user-fields-component.tsx b/arduino-ide-extension/src/browser/dialogs/user-fields/user-fields-component.tsx
index 8676dc74..ae8797fc 100644
--- a/arduino-ide-extension/src/browser/dialogs/user-fields/user-fields-component.tsx
+++ b/arduino-ide-extension/src/browser/dialogs/user-fields/user-fields-component.tsx
@@ -65,7 +65,11 @@ export const UserFieldsComponent = ({
                     type={field.secret ? 'password' : 'text'}
                     value={field.value}
                     className="theia-input"
-                    placeholder={'Enter ' + field.label}
+                    placeholder={nls.localize(
+                      'arduino/userFields/enterField',
+                      'Enter {0}',
+                      field.label
+                    )}
                     onChange={updateUserField(index)}
                   />
                 </div>
diff --git a/arduino-ide-extension/src/node/boards-service-impl.ts b/arduino-ide-extension/src/node/boards-service-impl.ts
index e4f1fad3..ccad3147 100644
--- a/arduino-ide-extension/src/node/boards-service-impl.ts
+++ b/arduino-ide-extension/src/node/boards-service-impl.ts
@@ -42,6 +42,7 @@ import {
 } from './cli-protocol/cc/arduino/cli/commands/v1/upload_pb';
 import { ExecuteWithProgress } from './grpc-progressible';
 import { ServiceError } from './service-error';
+import { nls } from '@theia/core/lib/common';
 
 @injectable()
 export class BoardsServiceImpl
@@ -319,7 +320,10 @@ export class BoardsServiceImpl
           .join(', '),
         installable: true,
         deprecated: platform.getDeprecated(),
-        summary: 'Boards included in this package:',
+        summary: nls.localize(
+          'arduino/component/boardsIncluded',
+          'Boards included in this package:'
+        ),
         installedVersion,
         boards: platform
           .getBoardsList()
diff --git a/i18n/en.json b/i18n/en.json
index 31a37863..3bf13c5f 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -17,6 +17,7 @@
       "installManually": "Install Manually",
       "installNow": "The \"{0} {1}\" core has to be installed for the currently selected \"{2}\" board. Do you want to install it now?",
       "noFQBN": "The FQBN is not available for the selected board \"{0}\". Do you have the corresponding core installed?",
+      "noPortsDiscovered": "No ports discovered",
       "noPortsSelected": "No ports selected for board: '{0}'.",
       "noneSelected": "No boards selected.",
       "openBoardsConfig": "Select other board and port…",
@@ -26,6 +27,7 @@
       "portLabel": "Port: {0}",
       "programmer": "Programmer",
       "reselectLater": "Reselect later",
+      "searchBoard": "SEARCH BOARD",
       "selectBoard": "Select Board",
       "selectBoardForInfo": "Please select a board to obtain board info.",
       "selectPortForInfo": "Please select a port to obtain board info.",
@@ -115,6 +117,7 @@
       "error": "Compilation error: {0}"
     },
     "component": {
+      "boardsIncluded": "Boards included in this package:",
       "by": "by",
       "filterSearch": "Filter your search...",
       "install": "INSTALL",
@@ -344,6 +347,7 @@
     },
     "userFields": {
       "cancel": "Cancel",
+      "enterField": "Enter {0}",
       "upload": "Upload"
     }
   },