jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-07-13 06:16:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix url to open sketch in cloud editor (#452)

Browse Source
This commit is contained in:
Alberto Iannaccone 2021-07-23 10:01:21 +02:00 committed by GitHub
parent d790266cc8
commit 5897f379a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-contributions.ts
View File

@ -176,7 +176,7 @@ export class CloudSketchbookContribution extends Contribution {
registry.registerCommand(CloudSketchbookCommands.OPEN_IN_CLOUD_EDITOR, {
execute: (arg) => {
this.windowService.openNewWindow(
`https://create.arduino.cc/editor/${arg.node.sketchId}`,
`https://create.arduino.cc/editor/${arg.username}/${arg.node.sketchId}`,
{ external: true }
);
},

4
arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-widget.tsx
View File

@ -94,7 +94,9 @@ export class CloudSketchbookTreeWidget extends SketchbookTreeWidget {
this.currentSketchUri === node.uri.toString())
) {
return Array.from(new Set(node.commands)).map((command) =>
this.renderInlineCommand(command.id, node)
this.renderInlineCommand(command.id, node, {
username: this.authenticationService.session?.account?.label,
})
);
}
return undefined;

5
arduino-ide-extension/src/browser/widgets/sketchbook/sketchbook-tree-widget.tsx
View File

@ -125,11 +125,12 @@ export class SketchbookTreeWidget extends FileTreeWidget {
protected renderInlineCommand(
commandId: string,
node: SketchbookTree.SketchDirNode
node: SketchbookTree.SketchDirNode,
options?: any
): React.ReactNode {
const command = this.commandRegistry.getCommand(commandId);
const icon = command?.iconClass;
const args = { model: this.model, node: node };
const args = { model: this.model, node: node, ...options };
if (
command &&
icon &&