jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-07-13 22:36:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable local windows signing for forks PR

Browse Source 
Resolves https://github.com/arduino/arduino-ide/issues/2545
This commit is contained in:
Giacomo Cusinato 2024-11-07 16:50:05 +02:00
parent 3ccc864453
commit 63e9dfd7f5
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/build.yml vendored
View File

@ -286,6 +286,8 @@ jobs:
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe" SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
WIN_CERT_PASSWORD: ${{ secrets.INSTALLER_CERT_WINDOWS_PASSWORD }} WIN_CERT_PASSWORD: ${{ secrets.INSTALLER_CERT_WINDOWS_PASSWORD }}
WIN_CERT_CONTAINER_NAME: ${{ secrets.INSTALLER_CERT_WINDOWS_CONTAINER }} WIN_CERT_CONTAINER_NAME: ${{ secrets.INSTALLER_CERT_WINDOWS_CONTAINER }}
WIN_SIGNING_ENABLED: ${{ !github.event.pull_request.head.repo.fork }}
strategy: strategy:
matrix: matrix:
config: ${{ fromJson(needs.select-targets.outputs.build-matrix) }} config: ${{ fromJson(needs.select-targets.outputs.build-matrix) }}

5
electron-app/scripts/windowsCustomSign.js
View File

@ -1,7 +1,10 @@
const childProcess = require('child_process'); const childProcess = require('child_process');
exports.default = async function (configuration) { exports.default = async function (configuration) {
if (!process.env.GITHUB_ACTIONS) { if (
!process.env.GITHUB_ACTIONS ||
process.env.WIN_SIGNING_ENABLED !== 'true'
) {
return; return;
} }