From 781747fe80e9029ab12919c42afd9d2a74976a23 Mon Sep 17 00:00:00 2001 From: Akos Kitta Date: Tue, 3 Nov 2020 16:40:28 +0100 Subject: [PATCH] Fixed the application name on macOS. Patch for eclipse-theia/theia#8701. Signed-off-by: Akos Kitta --- .../src/electron-main/theia/electron-main-application.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arduino-ide-extension/src/electron-main/theia/electron-main-application.ts b/arduino-ide-extension/src/electron-main/theia/electron-main-application.ts index 746ca585..4c79a8a4 100644 --- a/arduino-ide-extension/src/electron-main/theia/electron-main-application.ts +++ b/arduino-ide-extension/src/electron-main/theia/electron-main-application.ts @@ -3,11 +3,20 @@ import { app } from 'electron'; import { fork } from 'child_process'; import { AddressInfo } from 'net'; import { ElectronSecurityToken } from '@theia/core/lib/electron-common/electron-token'; +import { FrontendApplicationConfig } from '@theia/application-package/lib/application-props'; import { ElectronMainApplication as TheiaElectronMainApplication, TheiaBrowserWindowOptions } from '@theia/core/lib/electron-main/electron-main-application'; @injectable() export class ElectronMainApplication extends TheiaElectronMainApplication { + async start(config: FrontendApplicationConfig): Promise { + // Explicitly set the app name to have better menu items on macOS. ("About", "Hide", and "Quit") + // See: https://github.com/electron-userland/electron-builder/issues/2468 + // Regression in Theia: https://github.com/eclipse-theia/theia/issues/8701 + app.on('ready', () => app.setName(config.applicationName)); + return super.start(config); + } + protected async getDefaultBrowserWindowOptions(): Promise { const options = await super.getDefaultBrowserWindowOptions(); return {