mirror of
				https://github.com/arduino/arduino-ide.git
				synced 2025-11-04 07:58:33 +00:00 
			
		
		
		
	Show all network and serial ports.
Otherwise, unrecognized network boards are ignored by IDE2. Closes #1327 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
		@@ -335,17 +335,12 @@ export class BoardsConfig extends React.Component<
 | 
			
		||||
      ports = this.state.knownPorts;
 | 
			
		||||
    } else {
 | 
			
		||||
      ports = this.state.knownPorts.filter((port) => {
 | 
			
		||||
        if (port.protocol === 'serial') {
 | 
			
		||||
        if (port.protocol === 'serial' || port.protocol === 'network') {
 | 
			
		||||
          // Allow all `serial` and `network` boards.
 | 
			
		||||
          // IDE2 must support better label for unrecognized `network` boards: https://github.com/arduino/arduino-ide/issues/1331
 | 
			
		||||
          return true;
 | 
			
		||||
        }
 | 
			
		||||
        // All other ports with different protocol are
 | 
			
		||||
        // only shown if there is a recognized board
 | 
			
		||||
        // connected
 | 
			
		||||
        for (const board of this.availableBoards) {
 | 
			
		||||
          if (board.port?.address === port.address) {
 | 
			
		||||
            return true;
 | 
			
		||||
          }
 | 
			
		||||
        }
 | 
			
		||||
        return false;
 | 
			
		||||
      });
 | 
			
		||||
    }
 | 
			
		||||
    return !ports.length ? (
 | 
			
		||||
 
 | 
			
		||||
@@ -438,20 +438,11 @@ export class BoardsServiceProvider implements FrontendApplicationContribution {
 | 
			
		||||
    const availableBoards: AvailableBoard[] = [];
 | 
			
		||||
    const attachedBoards = this._attachedBoards.filter(({ port }) => !!port);
 | 
			
		||||
    const availableBoardPorts = availablePorts.filter((port) => {
 | 
			
		||||
      if (port.protocol === 'serial') {
 | 
			
		||||
        // We always show all serial ports, even if there
 | 
			
		||||
        // is no recognized board connected to it
 | 
			
		||||
      if (port.protocol === 'serial' || port.protocol === 'network') {
 | 
			
		||||
        // Allow all `serial` and `network` boards.
 | 
			
		||||
        // IDE2 must support better label for unrecognized `network` boards: https://github.com/arduino/arduino-ide/issues/1331
 | 
			
		||||
        return true;
 | 
			
		||||
      }
 | 
			
		||||
 | 
			
		||||
      // All other ports with different protocol are
 | 
			
		||||
      // only shown if there is a recognized board
 | 
			
		||||
      // connected
 | 
			
		||||
      for (const board of attachedBoards) {
 | 
			
		||||
        if (board.port?.address === port.address) {
 | 
			
		||||
          return true;
 | 
			
		||||
        }
 | 
			
		||||
      }
 | 
			
		||||
      return false;
 | 
			
		||||
    });
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user