From 8dbcb8bbb6e38ee49e9570b92400720d82235e45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Sp=C3=B6nemann?= Date: Tue, 14 Jan 2020 15:35:44 +0100 Subject: [PATCH] Fallback rendering in case a BoardPackage with no name or author is found (arduino/arduino-pro-ide#21) --- .../component-list/list-item-renderer.tsx | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arduino-ide-extension/src/browser/components/component-list/list-item-renderer.tsx b/arduino-ide-extension/src/browser/components/component-list/list-item-renderer.tsx index 478caaab..124b9474 100644 --- a/arduino-ide-extension/src/browser/components/component-list/list-item-renderer.tsx +++ b/arduino-ide-extension/src/browser/components/component-list/list-item-renderer.tsx @@ -27,8 +27,18 @@ export class ListItemRenderer { ): React.ReactNode { const { item } = input; - const name = {item.name}; - const author = {item.author}; + let nameAndAuthor: JSX.Element; + if (item.name && item.author) { + const name = {item.name}; + const author = {item.author}; + nameAndAuthor = {name} by {author} + } else if (item.name) { + nameAndAuthor = {item.name}; + } else if ((item as any).id) { + nameAndAuthor = {(item as any).id}; + } else { + nameAndAuthor = Unknown; + } const onClickUninstall = () => uninstall(item); const installedVersion = !!item.installedVersion &&
Version {item.installedVersion} @@ -71,7 +81,7 @@ export class ListItemRenderer { return
- {name} by {author} + {nameAndAuthor} {installedVersion}