jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-11-10 10:58:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

#1032 failing upload flag for monitor mgr (#1040)

Browse Source 
* 1032 failing upload flag for monitor mgr

* move upload failure fix logic to frontend

* misc corrections

* avoid starting monitor when upload is in progress

* avoid starting monitor when upload is in progress

* prevent monitor side effects on upload (WIP)

* send upload req after notifying mgr

* dispose instead of pause on upld (code not final)

* Revert "dispose instead of pause on upld (code not final)"

This reverts commit 2d5dff2a2d.

* force wait before upload (test)

* always start queued services after uplaod finishes

* test cli with monitor close delay

* clean up unnecessary await(s)

* remove unused dependency

* revert CLI to 0.23

* use master cli for testing, await in upload finish

* remove upload port from pending monitor requests

* fix startQueuedServices

* refinements queued monitors

* clean up monitor mgr state

* fix typo from prev cleanup

* avoid dupl queued monitor services

* variable name changes

* reference latest cli commit in package.json

Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
This commit is contained in:
David Simpson
2022-06-22 10:39:14 +02:00
committed by GitHub
parent 84109e416a
commit a54d7c8f45
6 changed files with 163 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arduino-ide-extension/src/node/core-service-impl.ts
View File

@@ -119,7 +119,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
return request;
}
async upload(options: CoreService.Upload.Options): Promise<void> {
upload(options: CoreService.Upload.Options): Promise<void> {
return this.doUpload(
options,
() => new UploadRequest(),