jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-06-14 16:16:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: relax accessible sketch path test condition

Browse Source 
- Do not expect `EACCESS` on Linux.
 - Run the test only if `EACCESS` occurs via the `stat` syscall.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
Akos Kitta 2023-10-09 17:08:00 +02:00 committed by Akos Kitta
parent 0b2410d49a
commit a8e63c8c90
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
arduino-ide-extension/src/test/node/sketches-service-impl.slow-test.ts
View File

@ -6,7 +6,6 @@ import { isWindows } from '@theia/core/lib/common/os';
import { FileUri } from '@theia/core/lib/node/file-uri'; import { FileUri } from '@theia/core/lib/node/file-uri';
import { Container } from '@theia/core/shared/inversify'; import { Container } from '@theia/core/shared/inversify';
import { expect } from 'chai'; import { expect } from 'chai';
import { rejects } from 'node:assert/strict';
import { promises as fs } from 'node:fs'; import { promises as fs } from 'node:fs';
import { basename, join } from 'node:path'; import { basename, join } from 'node:path';
import { sync as rimrafSync } from 'rimraf'; import { sync as rimrafSync } from 'rimraf';
@ -67,19 +66,30 @@ describe('isAccessibleSketchPath', () => {
expect(actual).to.be.equal(aSketchFilePath); expect(actual).to.be.equal(aSketchFilePath);
}); });
it('should ignore EACCESS (non-Windows)', async function () { it('should ignore EACCESS', async function () {
if (isWindows) {
// `stat` syscall does not result in an EACCESS on Windows after stripping the file permissions.
// an `open` syscall would, but IDE2 on purpose does not check the files.
// the sketch files are provided by the CLI after loading the sketch.
return this.skip();
}
const sketchFolderPath = join(testDirPath, 'my_sketch'); const sketchFolderPath = join(testDirPath, 'my_sketch');
const mainSketchFilePath = join(sketchFolderPath, 'my_sketch.ino'); const mainSketchFilePath = join(sketchFolderPath, 'my_sketch.ino');
await fs.mkdir(sketchFolderPath, { recursive: true }); await fs.mkdir(sketchFolderPath, { recursive: true });
await fs.writeFile(mainSketchFilePath, '', { encoding: 'utf8' }); await fs.writeFile(mainSketchFilePath, '', { encoding: 'utf8' });
await fs.chmod(mainSketchFilePath, 0o000); // remove all permissions await fs.chmod(mainSketchFilePath, 0o000); // remove all permissions
await rejects(fs.readFile(mainSketchFilePath), ErrnoException.isEACCES); try {
await fs.readFile(mainSketchFilePath);
// If reading the file without sufficient permissions does not result in EACCESS error, do not run the test.
// For example, a `stat` syscall does not result in an EACCESS on Windows after stripping the file permissions.
// an `open` syscall would, but IDE2 on purpose does not check the files.
// the sketch files are provided by the CLI after loading the sketch.
console.info(
'Skip. Reading the file content without permissions was successful.'
);
return this.skip();
} catch (err) {
expect(
ErrnoException.isEACCES(err),
`Expected an error with EACCES code. Got: ${
typeof err === 'object' ? JSON.stringify(err) : err
}`
).to.be.true;
}
const actual = await isAccessibleSketchPath(sketchFolderPath); const actual = await isAccessibleSketchPath(sketchFolderPath);
expect(actual).to.be.equal(mainSketchFilePath); expect(actual).to.be.equal(mainSketchFilePath);
}); });