jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-07-26 20:56:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

#944: Fixed auth. sessions not persistent (#992)

Browse Source
This commit is contained in:
David Simpson 2022-05-23 09:52:44 +02:00 committed by GitHub
parent b407d0aee0
commit b8c718ce9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arduino-ide-extension/src/browser/auth/authentication-client-service.ts
View File

@ -49,7 +49,10 @@ export class AuthenticationClientService
this.service this.service
.session() .session()
.then((session) => this.notifySessionDidChange(session)); .then((session) => this.notifySessionDidChange(session));
this.setOptions(); this.setOptions();
this.service.initAuthSession()
this.arduinoPreferences.onPreferenceChanged((event) => { this.arduinoPreferences.onPreferenceChanged((event) => {
if (event.preferenceName.startsWith('arduino.auth.')) { if (event.preferenceName.startsWith('arduino.auth.')) {
this.setOptions(); this.setOptions();

1
arduino-ide-extension/src/common/protocol/authentication-service.ts
View File

@ -23,6 +23,7 @@ export interface AuthenticationService
session(): Promise<AuthenticationSession | undefined>; session(): Promise<AuthenticationSession | undefined>;
disposeClient(client: AuthenticationServiceClient): void; disposeClient(client: AuthenticationServiceClient): void;
setOptions(authOptions: AuthOptions): void; setOptions(authOptions: AuthOptions): void;
initAuthSession(): Promise<void>;
} }
export interface AuthenticationServiceClient { export interface AuthenticationServiceClient {

10
arduino-ide-extension/src/node/auth/authentication-service-impl.ts
View File

@ -19,6 +19,8 @@ export class AuthenticationServiceImpl
protected readonly delegate = new ArduinoAuthenticationProvider(); protected readonly delegate = new ArduinoAuthenticationProvider();
protected readonly clients: AuthenticationServiceClient[] = []; protected readonly clients: AuthenticationServiceClient[] = [];
protected readonly toDispose = new DisposableCollection(); protected readonly toDispose = new DisposableCollection();
private initialized = false;
async onStart(): Promise<void> { async onStart(): Promise<void> {
this.toDispose.pushAll([ this.toDispose.pushAll([
@ -42,7 +44,13 @@ export class AuthenticationServiceImpl
this.clients.forEach((client) => this.disposeClient(client)) this.clients.forEach((client) => this.disposeClient(client))
), ),
]); ]);
await this.delegate.init(); }
async initAuthSession(): Promise<void> {
if (!this.initialized) {
await this.delegate.init();
this.initialized = true
}
} }
setOptions(authOptions: AuthOptions) { setOptions(authOptions: AuthOptions) {