jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-11-12 19:59:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use FQBN instead of Board for the monitor ID.

Browse Source 
Closes #1278

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
Akos Kitta
2022-08-03 09:01:18 +02:00
committed by Akos Kitta
parent d93c9ba654
commit d556ee95c0
3 changed files with 30 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
arduino-ide-extension/src/node/core-service-impl.ts
View File

@@ -23,7 +23,7 @@ import {
UploadUsingProgrammerResponse,
} from './cli-protocol/cc/arduino/cli/commands/v1/upload_pb';
import { ResponseService } from '../common/protocol/response-service';
import { Board, OutputMessage, Port, Status } from '../common/protocol';
import { OutputMessage, Port, Status } from '../common/protocol';
import { ArduinoCoreServiceClient } from './cli-protocol/cc/arduino/cli/commands/v1/commands_grpc_pb';
import { Port as GrpcPort } from './cli-protocol/cc/arduino/cli/commands/v1/port_pb';
import { ApplicationError, CommandService, Disposable, nls } from '@theia/core';
@@ -376,23 +376,23 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
}
private async notifyUploadWillStart({
board,
fqbn,
port,
}: {
board?: Board | undefined;
fqbn?: string | undefined;
port?: Port | undefined;
}): Promise<void> {
return this.monitorManager.notifyUploadStarted(board, port);
return this.monitorManager.notifyUploadStarted(fqbn, port);
}
private async notifyUploadDidFinish({
board,
fqbn,
port,
}: {
board?: Board | undefined;
fqbn?: string | undefined;
port?: Port | undefined;
}): Promise<Status> {
return this.monitorManager.notifyUploadFinished(board, port);
return this.monitorManager.notifyUploadFinished(fqbn, port);
}
private mergeSourceOverrides(