jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-11-11 19:29:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: the focus in the sketchbook widget

Browse Source 
Ref: arduino/arduino-ide#1720

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
Akos Kitta
2023-03-24 10:42:17 +01:00
committed by Akos Kitta
parent 6e72be1b4c
commit eb1f247296
4 changed files with 47 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
arduino-ide-extension/src/browser/widgets/sketchbook/sketchbook-composite-widget.tsx
View File

@@ -9,6 +9,7 @@ import { BaseWidget } from '@theia/core/lib/browser/widgets/widget';
import { CommandService } from '@theia/core/lib/common/command';
import { SketchbookTreeWidget } from './sketchbook-tree-widget';
import { CreateNew } from '../sketchbook/create-new';
import { findChildTheiaButton } from '../../utils/dom';
@injectable()
export abstract class BaseSketchbookCompositeWidget<
@@ -18,16 +19,17 @@ export abstract class BaseSketchbookCompositeWidget<
protected readonly commandService: CommandService;
private readonly compositeNode: HTMLElement;
private readonly footerNode: HTMLElement;
private readonly footerRoot: Root;
constructor() {
super();
this.compositeNode = document.createElement('div');
this.compositeNode.classList.add('composite-node');
const footerNode = document.createElement('div');
footerNode.classList.add('footer-node');
this.compositeNode.appendChild(footerNode);
this.footerRoot = createRoot(footerNode);
this.footerNode = document.createElement('div');
this.footerNode.classList.add('footer-node');
this.compositeNode.appendChild(this.footerNode);
this.footerRoot = createRoot(this.footerNode);
this.node.appendChild(this.compositeNode);
this.title.closable = false;
}
@@ -51,6 +53,7 @@ export abstract class BaseSketchbookCompositeWidget<
super.onActivateRequest(message);
// Sending a resize message is needed because otherwise the tree widget would render empty
this.onResize(Widget.ResizeMessage.UnknownSize);
findChildTheiaButton(this.footerNode, true)?.focus();
}
protected override onResize(message: Widget.ResizeMessage): void {

8
arduino-ide-extension/src/browser/widgets/sketchbook/sketchbook-widget.tsx
View File

@@ -128,13 +128,7 @@ export class SketchbookWidget extends BaseWidget {
protected override onActivateRequest(message: Message): void {
super.onActivateRequest(message);
// TODO: focus the active sketchbook
// if (this.editor) {
// this.editor.focus();
// } else {
// }
this.node.focus();
this.sketchbookCompositeWidget.activate();
}
protected override onResize(message: Widget.ResizeMessage): void {