jeans/arduino-ide
jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-06-20 02:56:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: show no errors if users cancel lib install

Browse Source 
Throwing and catching a `UserAbortError` is part of the natural flow.

Closes #2063

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
This commit is contained in:
Akos Kitta 2023-05-11 15:29:06 +02:00 committed by Akos Kitta
parent 31deeebb49
commit ee43a12eb7
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arduino-ide-extension/src/browser/widgets/component-list/filterable-list-container.tsx
View File

@ -13,7 +13,7 @@ import {
} from '../../../common/protocol/installable'; } from '../../../common/protocol/installable';
import { ArduinoComponent } from '../../../common/protocol/arduino-component'; import { ArduinoComponent } from '../../../common/protocol/arduino-component';
import { SearchBar } from './search-bar'; import { SearchBar } from './search-bar';
import { ListWidget } from './list-widget'; import { ListWidget, UserAbortError } from './list-widget';
import { ComponentList } from './component-list'; import { ComponentList } from './component-list';
import { ListItemRenderer } from './list-item-renderer'; import { ListItemRenderer } from './list-item-renderer';
import { import {
@ -148,6 +148,11 @@ export class FilterableListContainer<
try { try {
await install({ item, progressId, version }); await install({ item, progressId, version });
} catch (err) { } catch (err) {
if (err instanceof UserAbortError) {
// Do not toast an error message on user abort.
// https://github.com/arduino/arduino-ide/issues/2063
return;
}
const message = LibraryPackage.is(item) // TODO: this dispatch does not belong here const message = LibraryPackage.is(item) // TODO: this dispatch does not belong here
? libraryInstallFailed(name, version) ? libraryInstallFailed(name, version)
: platformInstallFailed(name, version); : platformInstallFailed(name, version);