jeans/arduino-ide
1
0
Fork 0
mirror of https://github.com/arduino/arduino-ide.git synced 2025-11-08 09:58:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor code improvements

Browse Source 
Signed-off-by: jbicker <jan.bicker@typefox.io>
This commit is contained in:
jbicker
2019-08-16 10:21:59 +02:00
parent 9b255ac072
commit f76f4543e9
6 changed files with 36 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
arduino-ide-extension/src/browser/monitor/monitor-widget.tsx
View File

@@ -71,12 +71,9 @@ export class SerialMonitorOutput extends React.Component<SerialMonitorOutput.Pro
fontFamily: 'monospace',
};
for (let text of this.props.lines) {
for (const text of this.props.lines) {
result += text;
}
if (result.length === 0) {
result = '';
}
return <React.Fragment>
<div style={style}>{result}</div>
<div style={{ float: "left", clear: "both" }}
@@ -116,7 +113,7 @@ export class MonitorWidget extends ReactWidget {
protected lines: string[];
protected tempData: string;
protected _baudRate: number;
protected baudRate: number;
protected _lineEnding: string;
constructor(
@@ -168,16 +165,12 @@ export class MonitorWidget extends ReactWidget {
this.update();
}
get baudRate(): number | undefined {
return this._baudRate;
}
protected onAfterAttach(msg: Message) {
super.onAfterAttach(msg);
this.clear();
this.connect();
this.toDisposeOnDetach.push(this.boardsServiceClient.onBoardsChanged(async states => {
const currentConnectionConfig = this.connection.connectionConfig;
const currentConnectionConfig = this.connection.connectionConfig;
const connectedBoard = states.newState.boards
.filter(AttachedSerialBoard.is)
.find(board => {
@@ -296,7 +289,7 @@ export class MonitorWidget extends ReactWidget {
}
protected readonly onChangeBaudRate = (br: SelectOption) => {
this._baudRate = typeof br.value === 'number' ? br.value : 9600;
this.baudRate = typeof br.value === 'number' ? br.value : 9600;
}
protected renderSelectField(id: string, options: OptionsType<SelectOption>, defaultVal: SelectOption, onChange: (v: SelectOption) => void): React.ReactNode {