Version 2.0.0-rc5 (#897)

Co-authored-by: Umberto Sgueglia <umberto.sgueglia@external.fcagroup.com>

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,15 @@
+### Motivation
+<!-- Why this pull request? -->
+
+### Change description
+<!-- What does your code do? -->
+
+### Other information
+<!-- Any additional information that could help the review process -->
+
+### Reviewer checklist
+
+* [ ] PR addresses a single concern.
+* [ ] The PR has no duplicates (please search among the [Pull Requests](https://github.com/arduino/arduino-ide/pulls) before creating one)
+* [ ] PR title and description are properly filled.
+* [ ] Docs have been added / updated (for bug fixes / features)

.github/workflows/compose-full-changelog.yaml

@@ -2,10 +2,13 @@ name: Compose full changelog
 
 on:
   release:
-    types: [created, edited]
+    types:
+      - edited
 
 env:
   CHANGELOG_ARTIFACTS: changelog
+  # See: https://github.com/actions/setup-node/#readme
+  NODE_VERSION: 14.x
 
 jobs:
   create-changelog:
@@ -15,6 +18,12 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
+      - name: Install Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          registry-url: 'https://registry.npmjs.org'
+
       - name: Get Tag
         id: tag_name
         run: |
@@ -26,7 +35,7 @@ jobs:
           mkdir "${{ github.workspace }}/${{ env.CHANGELOG_ARTIFACTS }}"
 
           # Get the changelog file name to build
-          CHANGELOG_FILE_NAME="${{ steps.tag_name.outputs.TAG_NAME }}-$(date --iso-8601=s).md"
+          CHANGELOG_FILE_NAME="${{ steps.tag_name.outputs.TAG_NAME }}-$(date +%s).md"
 
           # Create manifest file pointing to latest changelog file name
           echo "$CHANGELOG_FILE_NAME" >> "${{ github.workspace }}/${{ env.CHANGELOG_ARTIFACTS }}/latest.txt"

README.md

@@ -23,13 +23,14 @@ should be considered unstable:
 
 | Platform  | 32 bit                   | 64 bit                                                                                                 |
 | --------- | ------------------------ | ------------------------------------------------------------------------------------------------------ |
-| Linux     |                          | [Nightly Linux 64 bit]                                                                                 |
+| Linux     |                          | [Nightly Linux AppImage 64 bit]<br />[Nightly Linux ZIP file 64 bit]                                   |
 | Linux ARM | [🚧 Work in progress...] | [🚧 Work in progress...]                                                                               |
 | Windows   |                          | [Nightly Windows 64 bit installer]<br />[Nightly Windows 64 bit MSI]<br />[Nightly Windows 64 bit ZIP] |
 | macOS     |                          | [Nightly macOS 64 bit]                                                                                 |
 
 [🚧 work in progress...]: https://github.com/arduino/arduino-ide/issues/107
-[nightly linux 64 bit]: https://downloads.arduino.cc/arduino-ide/nightly/arduino-ide_nightly-latest_Linux_64bit.zip
+[nightly linux appimage 64 bit]: https://downloads.arduino.cc/arduino-ide/nightly/arduino-ide_nightly-latest_Linux_64bit.AppImage
+[nightly linux zip file 64 bit]: https://downloads.arduino.cc/arduino-ide/nightly/arduino-ide_nightly-latest_Linux_64bit.zip
 [nightly windows 64 bit installer]: https://downloads.arduino.cc/arduino-ide/nightly/arduino-ide_nightly-latest_Windows_64bit.exe
 [nightly windows 64 bit msi]: https://downloads.arduino.cc/arduino-ide/nightly/arduino-ide_nightly-latest_Windows_64bit.msi
 [nightly windows 64 bit zip]: https://downloads.arduino.cc/arduino-ide/nightly/arduino-ide_nightly-latest_Windows_64bit.zip

arduino-ide-extension/package.json

@@ -1,6 +1,6 @@
 {
   "name": "arduino-ide-extension",
-  "version": "2.0.0-rc4",
+  "version": "2.0.0-rc5",
   "description": "An extension for Theia building the Arduino IDE",
   "license": "AGPL-3.0-or-later",
   "scripts": {

arduino-ide-extension/src/browser/contributions/help.ts

@@ -14,6 +14,7 @@ import {
 } from './contribution';
 import { nls } from '@theia/core/lib/common';
 import { IDEUpdaterCommands } from '../ide-updater/ide-updater-commands';
+import { ElectronCommands } from '@theia/core/lib/electron-browser/menu/electron-menu-contribution';
 
 @injectable()
 export class Help extends Contribution {
@@ -84,9 +85,17 @@ export class Help extends Contribution {
       Help.Commands.VISIT_ARDUINO,
       createOpenHandler('https://www.arduino.cc/')
     );
+    registry.registerCommand(
+      Help.Commands.PRIVACY_POLICY,
+      createOpenHandler('https://www.arduino.cc/en/privacy-policy')
+    );
   }
 
   registerMenus(registry: MenuModelRegistry): void {
+    registry.unregisterMenuAction({
+      commandId: ElectronCommands.TOGGLE_DEVELOPER_TOOLS.id,
+    });
+
     registry.registerMenuAction(ArduinoMenus.HELP__MAIN_GROUP, {
       commandId: Help.Commands.GETTING_STARTED.id,
       order: '0',
@@ -117,9 +126,13 @@ export class Help extends Contribution {
       order: '6',
     });
     registry.registerMenuAction(ArduinoMenus.HELP__FIND_GROUP, {
-      commandId: IDEUpdaterCommands.CHECK_FOR_UPDATES.id,
+      commandId: Help.Commands.PRIVACY_POLICY.id,
       order: '7',
     });
+    registry.registerMenuAction(ArduinoMenus.HELP__FIND_GROUP, {
+      commandId: IDEUpdaterCommands.CHECK_FOR_UPDATES.id,
+      order: '8',
+    });
   }
 
   registerKeybindings(registry: KeybindingRegistry): void {
@@ -167,5 +180,10 @@ export namespace Help {
       label: nls.localize('arduino/help/visit', 'Visit Arduino.cc'),
       category: 'Arduino',
     };
+    export const PRIVACY_POLICY: Command = {
+      id: 'arduino-privacy-policy',
+      label: nls.localize('arduino/help/privacyPolicy', 'Privacy Policy'),
+      category: 'Arduino',
+    };
   }
 }

arduino-ide-extension/src/browser/create/create-api.ts

@@ -100,14 +100,29 @@ export class CreateApi {
     return result;
   }
 
-  async sketches(): Promise<Create.Sketch[]> {
+  async sketches(limit = 50): Promise<Create.Sketch[]> {
     const url = new URL(`${this.domain()}/sketches`);
     url.searchParams.set('user_id', 'me');
+    url.searchParams.set('limit', limit.toString());
     const headers = await this.headers();
-    const result = await this.run<{ sketches: Create.Sketch[] }>(url, {
+    const result: { sketches: Create.Sketch[] } = { sketches: [] };
+
+    let partialSketches: Create.Sketch[] = [];
+    let currentOffset = 0;
+    do {
+      url.searchParams.set('offset', currentOffset.toString());
+      partialSketches = (
+        await this.run<{ sketches: Create.Sketch[] }>(url, {
           method: 'GET',
           headers,
-    });
+        })
+      ).sketches;
+      if (partialSketches.length != 0) {
+        result.sketches = result.sketches.concat(partialSketches);
+      }
+      currentOffset = currentOffset + limit;
+    } while (partialSketches.length != 0);
+
     result.sketches.forEach((sketch) => this.sketchCache.addSketch(sketch));
     return result.sketches;
   }

arduino-ide-extension/src/electron-main/theia/electron-main-application.ts

@@ -18,6 +18,7 @@ import { URI } from '@theia/core/shared/vscode-uri';
 import * as electronRemoteMain from '@theia/core/electron-shared/@electron/remote/main';
 import { Deferred } from '@theia/core/lib/common/promise-util';
 import * as os from '@theia/core/lib/common/os';
+import { RELOAD_REQUESTED_SIGNAL, Restart } from '@theia/core/lib/electron-common/messaging/electron-messages';
 
 app.commandLine.appendSwitch('disable-http-cache');
 
@@ -157,7 +158,9 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
     app.on('second-instance', this.onSecondInstance.bind(this));
     app.on('window-all-closed', this.onWindowAllClosed.bind(this));
 
-    ipcMain.on('restart', ({ sender }) => {
+    ipcMain.on(RELOAD_REQUESTED_SIGNAL, event => this.handleReload(event));
+
+    ipcMain.on(Restart, ({ sender }) => {
       this.restart(sender.id);
     });
   }

arduino-ide-extension/src/node/sketches-service-impl.ts

@@ -30,10 +30,11 @@ const WIN32_DRIVE_REGEXP = /^[a-zA-Z]:\\/;
 const prefix = '.arduinoIDE-unsaved';
 
 @injectable()
-export class SketchesServiceImpl
-  extends CoreClientAware
-  implements SketchesService
-{
+export class SketchesServiceImpl extends CoreClientAware
+  implements SketchesService {
+  private sketchSuffixIndex = 1;
+  private lastSketchBaseName: string;
+
   @inject(ConfigService)
   protected readonly configService: ConfigService;
 
@@ -303,22 +304,31 @@ export class SketchesServiceImpl
       monthNames[today.getMonth()]
     }${today.getDate()}`;
     const config = await this.configService.getConfiguration();
-    const user = FileUri.fsPath(config.sketchDirUri);
+    const sketchbookPath = FileUri.fsPath(config.sketchDirUri);
     let sketchName: string | undefined;
-    for (let i = 97; i < 97 + 26; i++) {
-      const sketchNameCandidate = `${sketchBaseName}${String.fromCharCode(i)}`;
-      // Note: we check the future destination folder (`directories.user`) for name collision and not the temp folder!
-      if (await promisify(fs.exists)(path.join(user, sketchNameCandidate))) {
-        continue;
-      }
 
+    // If it's another day, reset the count of sketches created today
+    if (this.lastSketchBaseName !== sketchBaseName) this.sketchSuffixIndex = 1;
+
+    let nameFound = false;
+    while (!nameFound) {
+      const sketchNameCandidate = `${sketchBaseName}${sketchIndexToLetters(
+        this.sketchSuffixIndex++
+      )}`;
+      // Note: we check the future destination folder (`directories.user`) for name collision and not the temp folder!
+      const sketchExists = await promisify(fs.exists)(
+        path.join(sketchbookPath, sketchNameCandidate)
+      );
+      if (!sketchExists) {
+        nameFound = true;
         sketchName = sketchNameCandidate;
-      break;
+      }
     }
 
     if (!sketchName) {
       throw new Error('Cannot create a unique sketch name');
     }
+    this.lastSketchBaseName = sketchBaseName;
 
     const sketchDir = path.join(parentPath, sketchName);
     const sketchFile = path.join(sketchDir, `${sketchName}.ino`);
@@ -507,3 +517,23 @@ interface SketchContainerWithDetails extends SketchContainer {
   readonly children: SketchContainerWithDetails[];
   readonly sketches: SketchWithDetails[];
 }
+
+/*
+ * When a new sketch is created, add a suffix to distinguish it
+ * from other new sketches I created today.
+ * If 'sketch_jul8a' is already used, go with 'sketch_jul8b'.
+ * If 'sketch_jul8b' already used, go with 'sketch_jul8c'.
+ * When it reacheas 'sketch_jul8z', go with 'sketch_jul8aa',
+ * and so on.
+ */
+function sketchIndexToLetters(num: number): string {
+  let out = '';
+  let pow;
+  do {
+    pow = Math.floor(num / 26);
+    const mod = num % 26;
+    out = (mod ? String.fromCharCode(96 + mod) : (--pow, 'z')) + out;
+    num = pow;
+  } while (pow > 0);
+  return out;
+}

browser-app/package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "browser-app",
-  "version": "2.0.0-rc4",
+  "version": "2.0.0-rc5",
   "license": "AGPL-3.0-or-later",
   "dependencies": {
     "@theia/core": "1.22.1",
@@ -20,7 +20,7 @@
     "@theia/process": "1.22.1",
     "@theia/terminal": "1.22.1",
     "@theia/workspace": "1.22.1",
-    "arduino-ide-extension": "2.0.0-rc4"
+    "arduino-ide-extension": "2.0.0-rc5"
   },
   "devDependencies": {
     "@theia/cli": "1.22.1"

electron-app/package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "electron-app",
-  "version": "2.0.0-rc4",
+  "version": "2.0.0-rc5",
   "license": "AGPL-3.0-or-later",
   "main": "src-gen/frontend/electron-main.js",
   "dependencies": {
@@ -22,7 +22,7 @@
     "@theia/process": "1.22.1",
     "@theia/terminal": "1.22.1",
     "@theia/workspace": "1.22.1",
-    "arduino-ide-extension": "2.0.0-rc4"
+    "arduino-ide-extension": "2.0.0-rc5"
   },
   "devDependencies": {
     "@theia/cli": "1.22.1",

electron/build/resources/eula.txt

@@ -1,5 +1,3 @@
 Terms of Service
 
-By downloading the software from this page, you agree to the specified terms.
-
 The Arduino software is provided to you "as is" and we make no express or implied warranties whatsoever with respect to its functionality, operability, or use, including, without limitation, any implied warranties of merchantability, fitness for a particular purpose, or infringement. We expressly disclaim any liability whatsoever for any direct, indirect, consequential, incidental or special damages, including, without limitation, lost revenues, lost profits, losses resulting from business interruption or loss of data, regardless of the form of action or legal theory under which the liability may be asserted, even if advised of the possibility or likelihood of such damages.

i18n/en.json

@@ -238,7 +238,8 @@
             "reference": "Reference",
             "findInReference": "Find in Reference",
             "faq": "Frequently Asked Questions",
-            "visit": "Visit Arduino.cc"
+            "visit": "Visit Arduino.cc",
+            "privacyPolicy": "Privacy Policy"
         },
         "certificate": {
             "uploadRootCertificates": "Upload SSL Root Certificates",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "arduino-ide",
-  "version": "2.0.0-rc4",
+  "version": "2.0.0-rc5",
   "description": "Arduino IDE",
   "repository": "https://github.com/arduino/arduino-ide.git",
   "author": "Arduino SA",