jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 09:47:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary method in UniFi entity loader (#113597)

Browse Source
This commit is contained in:
Robert Svensson 2024-03-16 18:41:00 +01:00 committed by GitHub
parent ccd2e989c3
commit 00361f5293
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 31 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
homeassistant/components/unifi/hub/entity_loader.py
View File

@ -6,7 +6,6 @@ Make sure expected clients are available for platforms.
from __future__ import annotations from __future__ import annotations
import asyncio import asyncio
from collections.abc import Iterable
from datetime import timedelta from datetime import timedelta
from functools import partial from functools import partial
from typing import TYPE_CHECKING from typing import TYPE_CHECKING
@ -143,42 +142,36 @@ class UnifiEntityLoader:
"""Subscribe to UniFi API handlers and create entities.""" """Subscribe to UniFi API handlers and create entities."""
@callback @callback
def async_load_entities(descriptions: Iterable[UnifiEntityDescription]) -> None: def _add_unifi_entities() -> None:
"""Load and subscribe to UniFi endpoints.""" """Add UniFi entity."""
async_add_entities(
@callback unifi_platform_entity(obj_id, self.hub, description)
def _add_unifi_entities() -> None: for description in descriptions
"""Add UniFi entity.""" for obj_id in description.api_handler_fn(self.hub.api)
async_add_entities( if self._should_add_entity(description, obj_id)
unifi_platform_entity(obj_id, self.hub, description)
for description in descriptions
for obj_id in description.api_handler_fn(self.hub.api)
if self._should_add_entity(description, obj_id)
)
_add_unifi_entities()
@callback
def _create_unifi_entity(
description: UnifiEntityDescription, event: ItemEvent, obj_id: str
) -> None:
"""Create new UniFi entity on event."""
if self._should_add_entity(description, obj_id):
async_add_entities(
[unifi_platform_entity(obj_id, self.hub, description)]
)
for description in descriptions:
description.api_handler_fn(self.hub.api).subscribe(
partial(_create_unifi_entity, description), ItemEvent.ADDED
)
self.hub.config.entry.async_on_unload(
async_dispatcher_connect(
self.hub.hass,
self.hub.signal_options_update,
_add_unifi_entities,
)
) )
async_load_entities(descriptions) _add_unifi_entities()
@callback
def _create_unifi_entity(
description: UnifiEntityDescription, event: ItemEvent, obj_id: str
) -> None:
"""Create new UniFi entity on event."""
if self._should_add_entity(description, obj_id):
async_add_entities(
[unifi_platform_entity(obj_id, self.hub, description)]
)
for description in descriptions:
description.api_handler_fn(self.hub.api).subscribe(
partial(_create_unifi_entity, description), ItemEvent.ADDED
)
self.hub.config.entry.async_on_unload(
async_dispatcher_connect(
self.hub.hass,
self.hub.signal_options_update,
_add_unifi_entities,
)
)