jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-21 12:17:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use reference strings in Huawei LTE (#41011)

Browse Source 
* Update strings.json

* Update config_flow.py

* Update test_config_flow.py

* Update strings.json

* Update strings.json

* Update config_flow.py

* Update test_config_flow.py
This commit is contained in:
SNoof85 2020-10-02 22:43:57 +02:00 committed by GitHub
parent d3a0743fea
commit 005898a0d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/huawei_lte/config_flow.py
View File

@ -189,7 +189,7 @@ class ConfigFlowHandler(config_entries.ConfigFlow, domain=DOMAIN):
except LoginErrorPasswordWrongException: except LoginErrorPasswordWrongException:
errors[CONF_PASSWORD] = "incorrect_password" errors[CONF_PASSWORD] = "incorrect_password"
except LoginErrorUsernamePasswordWrongException: except LoginErrorUsernamePasswordWrongException:
errors[CONF_USERNAME] = "incorrect_username_or_password" errors[CONF_USERNAME] = "invalid_auth"
except LoginErrorUsernamePasswordOverrunException: except LoginErrorUsernamePasswordOverrunException:
errors["base"] = "login_attempts_exceeded" errors["base"] = "login_attempts_exceeded"
except ResponseErrorException: except ResponseErrorException:
@ -200,7 +200,7 @@ class ConfigFlowHandler(config_entries.ConfigFlow, domain=DOMAIN):
errors[CONF_URL] = "connection_timeout" errors[CONF_URL] = "connection_timeout"
except Exception: # pylint: disable=broad-except except Exception: # pylint: disable=broad-except
_LOGGER.warning("Unknown error connecting to device", exc_info=True) _LOGGER.warning("Unknown error connecting to device", exc_info=True)
errors[CONF_URL] = "unknown_connection_error" errors[CONF_URL] = "unknown"
if errors: if errors:
await self.hass.async_add_executor_job(logout) await self.hass.async_add_executor_job(logout)
return await self._async_show_user_form( return await self._async_show_user_form(

7
homeassistant/components/huawei_lte/strings.json
View File

@ -1,20 +1,19 @@
{ {
"config": { "config": {
"abort": { "abort": {
"already_configured": "This device has already been configured", "already_configured": "[%key:common::config_flow::abort::already_configured_device%]",
"already_in_progress": "This device is already being configured", "already_in_progress": "This device is already being configured",
"not_huawei_lte": "Not a Huawei LTE device" "not_huawei_lte": "Not a Huawei LTE device"
}, },
"error": { "error": {
"connection_failed": "Connection failed",
"connection_timeout": "Connection timeout", "connection_timeout": "Connection timeout",
"incorrect_password": "Incorrect password", "incorrect_password": "Incorrect password",
"incorrect_username": "Incorrect username", "incorrect_username": "Incorrect username",
"incorrect_username_or_password": "Incorrect username or password", "invalid_auth": "[%key:common::config_flow::error::invalid_auth%]",
"invalid_url": "Invalid URL", "invalid_url": "Invalid URL",
"login_attempts_exceeded": "Maximum login attempts exceeded, please try again later", "login_attempts_exceeded": "Maximum login attempts exceeded, please try again later",
"response_error": "Unknown error from device", "response_error": "Unknown error from device",
"unknown_connection_error": "Unknown error connecting to device" "unknown": "[%key:common::config_flow::error::unknown%]"
}, },
"flow_title": "Huawei LTE: {name}", "flow_title": "Huawei LTE: {name}",
"step": { "step": {

4
tests/components/huawei_lte/test_config_flow.py
View File

@ -84,7 +84,7 @@ async def test_connection_error(hass, requests_mock):
assert result["type"] == data_entry_flow.RESULT_TYPE_FORM assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
assert result["step_id"] == "user" assert result["step_id"] == "user"
assert result["errors"] == {CONF_URL: "unknown_connection_error"} assert result["errors"] == {CONF_URL: "unknown"}
@pytest.fixture @pytest.fixture
@ -111,7 +111,7 @@ def login_requests_mock(requests_mock):
(LoginErrorEnum.PASSWORD_WRONG, {CONF_PASSWORD: "incorrect_password"}), (LoginErrorEnum.PASSWORD_WRONG, {CONF_PASSWORD: "incorrect_password"}),
( (
LoginErrorEnum.USERNAME_PWD_WRONG, LoginErrorEnum.USERNAME_PWD_WRONG,
{CONF_USERNAME: "incorrect_username_or_password"}, {CONF_USERNAME: "invalid_auth"},
), ),
(LoginErrorEnum.USERNAME_PWD_ORERRUN, {"base": "login_attempts_exceeded"}), (LoginErrorEnum.USERNAME_PWD_ORERRUN, {"base": "login_attempts_exceeded"}),
(ResponseCodeEnum.ERROR_SYSTEM_UNKNOWN, {"base": "response_error"}), (ResponseCodeEnum.ERROR_SYSTEM_UNKNOWN, {"base": "response_error"}),