From 035e19be01ae7883eebfae9597a143fb88303252 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Mon, 3 Jun 2024 16:29:50 -0400 Subject: [PATCH] Google Gen AI: Copy messages to avoid changing the trace data (#118745) --- .../google_generative_ai_conversation/conversation.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/google_generative_ai_conversation/conversation.py b/homeassistant/components/google_generative_ai_conversation/conversation.py index 2c0b37a1216..6b2f3c11dcc 100644 --- a/homeassistant/components/google_generative_ai_conversation/conversation.py +++ b/homeassistant/components/google_generative_ai_conversation/conversation.py @@ -225,7 +225,7 @@ class GoogleGenerativeAIConversationEntity( messages = self.history[conversation_id] else: conversation_id = ulid.ulid_now() - messages = [{}, {}] + messages = [{}, {"role": "model", "parts": "Ok"}] if ( user_input.context @@ -272,8 +272,11 @@ class GoogleGenerativeAIConversationEntity( response=intent_response, conversation_id=conversation_id ) - messages[0] = {"role": "user", "parts": prompt} - messages[1] = {"role": "model", "parts": "Ok"} + # Make a copy, because we attach it to the trace event. + messages = [ + {"role": "user", "parts": prompt}, + *messages[1:], + ] LOGGER.debug("Input: '%s' with history: %s", user_input.text, messages) trace.async_conversation_trace_append(