jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 19:27:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use reference strings in Synology_DSM (#41333)

Browse Source 
* Update strings.json

* Update config_flow.py

* Update test_config_flow.py
This commit is contained in:
SNoof85 2020-10-06 15:35:36 +02:00 committed by GitHub
parent 46b2c776db
commit 0460166c7c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/synology_dsm/config_flow.py
View File

@ -140,10 +140,10 @@ class SynologyDSMFlowHandler(config_entries.ConfigFlow, domain=DOMAIN):
return await self.async_step_2sa(user_input, errors) return await self.async_step_2sa(user_input, errors)
except SynologyDSMLoginInvalidException as ex: except SynologyDSMLoginInvalidException as ex:
_LOGGER.error(ex) _LOGGER.error(ex)
errors[CONF_USERNAME] = "login" errors[CONF_USERNAME] = "invalid_auth"
except SynologyDSMRequestException as ex: except SynologyDSMRequestException as ex:
_LOGGER.error(ex) _LOGGER.error(ex)
errors[CONF_HOST] = "connection" errors[CONF_HOST] = "cannot_connect"
except SynologyDSMException as ex: except SynologyDSMException as ex:
_LOGGER.error(ex) _LOGGER.error(ex)
errors["base"] = "unknown" errors["base"] = "unknown"

8
homeassistant/components/synology_dsm/strings.json
View File

@ -30,14 +30,14 @@
} }
}, },
"error": { "error": {
"connection": "Connection error: please check your host, port & ssl", "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]",
"login": "Login error: please check your username & password", "invalid_auth": "[%key:common::config_flow::error::invalid_auth%]",
"missing_data": "Missing data: please retry later or an other configuration", "missing_data": "Missing data: please retry later or an other configuration",
"otp_failed": "Two-step authentication failed, retry with a new pass code", "otp_failed": "Two-step authentication failed, retry with a new pass code",
"unknown": "Unknown error: please check logs to get more details" "unknown": "[%key:common::config_flow::error::unknown%]"
}, },
"abort": { "abort": {
"already_configured": "Host already configured" "already_configured": "[%key:common::config_flow::abort::already_configured_device%]"
} }
}, },
"options": { "options": {

4
tests/components/synology_dsm/test_config_flow.py
View File

@ -290,7 +290,7 @@ async def test_login_failed(hass: HomeAssistantType, service: MagicMock):
data={CONF_HOST: HOST, CONF_USERNAME: USERNAME, CONF_PASSWORD: PASSWORD}, data={CONF_HOST: HOST, CONF_USERNAME: USERNAME, CONF_PASSWORD: PASSWORD},
) )
assert result["type"] == data_entry_flow.RESULT_TYPE_FORM assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
assert result["errors"] == {CONF_USERNAME: "login"} assert result["errors"] == {CONF_USERNAME: "invalid_auth"}
async def test_connection_failed(hass: HomeAssistantType, service: MagicMock): async def test_connection_failed(hass: HomeAssistantType, service: MagicMock):
@ -306,7 +306,7 @@ async def test_connection_failed(hass: HomeAssistantType, service: MagicMock):
) )
assert result["type"] == data_entry_flow.RESULT_TYPE_FORM assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
assert result["errors"] == {CONF_HOST: "connection"} assert result["errors"] == {CONF_HOST: "cannot_connect"}
async def test_unknown_failed(hass: HomeAssistantType, service: MagicMock): async def test_unknown_failed(hass: HomeAssistantType, service: MagicMock):