jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 11:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix radiothermostat -1 value issue (#8395)

Browse Source 
* Fix -1 value issue

Fixed issue where thermostat will sometimes return a current temperature or set temperature value of -1

* Update radiotherm.py

* Update radiotherm.py

* Update radiotherm.py

Added retry limit

* Update radiotherm.py

* Update radiotherm.py
This commit is contained in:
Andrew 2017-07-11 03:12:51 -05:00 committed by Pascal Vizeli
parent f5e24cb0bb
commit 04b1621b65
1 changed files with 38 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
homeassistant/components/climate/radiotherm.py
View File

@ -136,24 +136,53 @@ class RadioThermostat(ClimateDevice):
return self._away return self._away
def update(self): def update(self):
"""Update the data from the thermostat.""" """Update and validate the data from the thermostat."""
self._current_temperature = self.device.temp['raw'] current_temp = self.device.temp['raw']
if current_temp == -1:
_LOGGER.error("Couldn't get valid temperature reading")
return
self._current_temperature = current_temp
self._name = self.device.name['raw'] self._name = self.device.name['raw']
self._fmode = self.device.fmode['human'] try:
self._tmode = self.device.tmode['human'] self._fmode = self.device.fmode['human']
self._tstate = self.device.tstate['human'] except AttributeError:
_LOGGER.error("Couldn't get valid fan mode reading")
try:
self._tmode = self.device.tmode['human']
except AttributeError:
_LOGGER.error("Couldn't get valid thermostat mode reading")
try:
self._tstate = self.device.tstate['human']
except AttributeError:
_LOGGER.error("Couldn't get valid thermostat state reading")
if self._tmode == 'Cool': if self._tmode == 'Cool':
self._target_temperature = self.device.t_cool['raw'] target_temp = self.device.t_cool['raw']
if target_temp == -1:
_LOGGER.error("Couldn't get target reading")
return
self._target_temperature = target_temp
self._current_operation = STATE_COOL self._current_operation = STATE_COOL
elif self._tmode == 'Heat': elif self._tmode == 'Heat':
self._target_temperature = self.device.t_heat['raw'] target_temp = self.device.t_heat['raw']
if target_temp == -1:
_LOGGER.error("Couldn't get valid target reading")
return
self._target_temperature = target_temp
self._current_operation = STATE_HEAT self._current_operation = STATE_HEAT
elif self._tmode == 'Auto': elif self._tmode == 'Auto':
if self._tstate == 'Cool': if self._tstate == 'Cool':
self._target_temperature = self.device.t_cool['raw'] target_temp = self.device.t_cool['raw']
if target_temp == -1:
_LOGGER.error("Couldn't get valid target reading")
return
self._target_temperature = target_temp
elif self._tstate == 'Heat': elif self._tstate == 'Heat':
self._target_temperature = self.device.t_heat['raw'] target_temp = self.device.t_heat['raw']
if target_temp == -1:
_LOGGER.error("Couldn't get valid target reading")
return
self._target_temperature = target_temp
self._current_operation = STATE_AUTO self._current_operation = STATE_AUTO
else: else:
self._current_operation = STATE_IDLE self._current_operation = STATE_IDLE