From 06e5314bc87d1a8607dd064770f802431c53aa41 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Sat, 29 May 2021 17:28:32 +0200 Subject: [PATCH] Cleanup commented code + comprehensions in iOS (#51238) --- homeassistant/components/ios/__init__.py | 28 +++++++++--------------- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/homeassistant/components/ios/__init__.py b/homeassistant/components/ios/__init__.py index 2feafba949d..6797da9d8a6 100644 --- a/homeassistant/components/ios/__init__.py +++ b/homeassistant/components/ios/__init__.py @@ -212,20 +212,20 @@ CONFIGURATION_FILE = ".ios.conf" def devices_with_push(hass): """Return a dictionary of push enabled targets.""" - targets = {} - for device_name, device in hass.data[DOMAIN][ATTR_DEVICES].items(): - if device.get(ATTR_PUSH_ID) is not None: - targets[device_name] = device.get(ATTR_PUSH_ID) - return targets + return { + device_name: device.get(ATTR_PUSH_ID) + for device_name, device in hass.data[DOMAIN][ATTR_DEVICES].items() + if device.get(ATTR_PUSH_ID) is not None + } def enabled_push_ids(hass): """Return a list of push enabled target push IDs.""" - push_ids = [] - for device in hass.data[DOMAIN][ATTR_DEVICES].values(): - if device.get(ATTR_PUSH_ID) is not None: - push_ids.append(device.get(ATTR_PUSH_ID)) - return push_ids + return [ + device.get(ATTR_PUSH_ID) + for device in hass.data[DOMAIN][ATTR_DEVICES].values() + if device.get(ATTR_PUSH_ID) is not None + ] def devices(hass): @@ -337,14 +337,6 @@ class iOSIdentifyDeviceView(HomeAssistantView): hass = request.app["hass"] - # Commented for now while iOS app is getting frequent updates - # try: - # data = IDENTIFY_SCHEMA(req_data) - # except vol.Invalid as ex: - # return self.json_message( - # vol.humanize.humanize_error(request.json, ex), - # HTTP_BAD_REQUEST) - data[ATTR_LAST_SEEN_AT] = datetime.datetime.now().isoformat() device_id = data[ATTR_DEVICE_ID]