From 06f2aa93a4c21677209f7c352d9436dcf6fc2f25 Mon Sep 17 00:00:00 2001
From: Otto Winter <otto@otto-winter.com>
Date: Fri, 15 Feb 2019 18:40:46 +0100
Subject: [PATCH] Add persistent notification

---
 homeassistant/bootstrap.py                 | 17 +++++++++++++++++
 homeassistant/helpers/config_validation.py | 20 +++++++++++---------
 2 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/homeassistant/bootstrap.py b/homeassistant/bootstrap.py
index 90a74f23598..7e12a516478 100644
--- a/homeassistant/bootstrap.py
+++ b/homeassistant/bootstrap.py
@@ -192,6 +192,23 @@ async def async_from_config_dict(config: Dict[str, Any],
             '\n\n'.join(msg), "Config Warning", "config_warning"
         )
 
+    # TEMP: warn users for invalid slugs
+    # Remove after 0.92
+    if cv.INVALID_EXTRA_KEYS_FOUND:
+        msg = []
+        msg.append(
+            "Your configuration contains extra keys "
+            "that the platform does not support (but were silently "
+            "accepted before 0.88). Please find and remove the following."
+            "This will become a breaking change."
+        )
+        msg.append('\n'.join('- {}'.format(it)
+                             for it in cv.INVALID_EXTRA_KEYS_FOUND))
+
+        hass.components.persistent_notification.async_create(
+            '\n\n'.join(msg), "Config Warning", "config_warning"
+        )
+
     return hass
 
 
diff --git a/homeassistant/helpers/config_validation.py b/homeassistant/helpers/config_validation.py
index f10cf9e057e..41a55dc38dc 100644
--- a/homeassistant/helpers/config_validation.py
+++ b/homeassistant/helpers/config_validation.py
@@ -25,8 +25,6 @@ from homeassistant.helpers import template as template_helper
 from homeassistant.helpers.logging import KeywordStyleAdapter
 from homeassistant.util import slugify as util_slugify
 
-_LOGGER = logging.getLogger(__name__)
-
 # pylint: disable=invalid-name
 
 TIME_PERIOD_ERROR = "offset {} should be format 'HH:MM' or 'HH:MM:SS'"
@@ -36,6 +34,7 @@ OLD_ENTITY_ID_VALIDATION = r"^(\w+)\.(\w+)$"
 # persistent notification. Rare temporary exception to use a global.
 INVALID_SLUGS_FOUND = {}
 INVALID_ENTITY_IDS_FOUND = {}
+INVALID_EXTRA_KEYS_FOUND = []
 
 
 # Home Assistant types
@@ -661,14 +660,17 @@ class HASchema(vol.Schema):
                               if err.error_message == 'extra keys not allowed']
             if extra_key_errs:
                 msg = "Your configuration contains extra keys " \
-                      "that the platform does not support. The keys "
-                msg += ', '.join('[{}]'.format(err.path[-1]) for err in
-                                 extra_key_errs)
-                msg += ' are 42.'
+                      "that the platform does not support.\n" \
+                      "Please remove "
+                submsg = ', '.join('[{}]'.format(err.path[-1]) for err in
+                                   extra_key_errs)
+                submsg += '. '
                 if hasattr(data, '__config_file__'):
-                    msg += " (See {}, line {}). ".format(data.__config_file__,
-                                                         data.__line__)
-                _LOGGER.warning(msg)
+                    submsg += " (See {}, line {}). ".format(
+                        data.__config_file__, data.__line__)
+                msg += submsg
+                logging.getLogger(__name__).warning(msg)
+                INVALID_EXTRA_KEYS_FOUND.append(submsg)
             else:
                 # This should not happen (all errors should be extra key
                 # errors). Let's raise the original error anyway.