jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-06-29 09:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add handling for RoborockTooFrequentCodeRequests for roborock integration (#123759)

Browse Source 
* Add handling for RoborockTooFrequentCodeRequests

* Add tests for coverage
This commit is contained in:
Yuxin Wang 2024-08-20 00:09:01 -04:00 committed by GitHub
parent d8cbb3540f
commit 097162eceb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/roborock/config_flow.py
View File

@ -12,6 +12,7 @@ from roborock.exceptions import (
RoborockException, RoborockException,
RoborockInvalidCode, RoborockInvalidCode,
RoborockInvalidEmail, RoborockInvalidEmail,
RoborockTooFrequentCodeRequests,
RoborockUrlException, RoborockUrlException,
) )
from roborock.web_api import RoborockApiClient from roborock.web_api import RoborockApiClient
@ -83,6 +84,8 @@ class RoborockFlowHandler(ConfigFlow, domain=DOMAIN):
errors["base"] = "unknown_url" errors["base"] = "unknown_url"
except RoborockInvalidEmail: except RoborockInvalidEmail:
errors["base"] = "invalid_email_format" errors["base"] = "invalid_email_format"
except RoborockTooFrequentCodeRequests:
errors["base"] = "too_frequent_code_requests"
except RoborockException: except RoborockException:
_LOGGER.exception("Unexpected exception") _LOGGER.exception("Unexpected exception")
errors["base"] = "unknown_roborock" errors["base"] = "unknown_roborock"

1
homeassistant/components/roborock/strings.json
View File

@ -22,6 +22,7 @@
"invalid_code": "The code you entered was incorrect, please check it and try again.", "invalid_code": "The code you entered was incorrect, please check it and try again.",
"invalid_email": "There is no account associated with the email you entered, please try again.", "invalid_email": "There is no account associated with the email you entered, please try again.",
"invalid_email_format": "There is an issue with the formatting of your email - please try again.", "invalid_email_format": "There is an issue with the formatting of your email - please try again.",
"too_frequent_code_requests": "You have attempted to request too many codes. Try again later.",
"unknown_roborock": "There was an unknown roborock exception - please check your logs.", "unknown_roborock": "There was an unknown roborock exception - please check your logs.",
"unknown_url": "There was an issue determining the correct url for your roborock account - please check your logs.", "unknown_url": "There was an issue determining the correct url for your roborock account - please check your logs.",
"unknown": "[%key:common::config_flow::error::unknown%]" "unknown": "[%key:common::config_flow::error::unknown%]"

2
tests/components/roborock/test_config_flow.py
View File

@ -4,6 +4,7 @@ from copy import deepcopy
from unittest.mock import patch from unittest.mock import patch
import pytest import pytest
from roborock import RoborockTooFrequentCodeRequests
from roborock.exceptions import ( from roborock.exceptions import (
RoborockAccountDoesNotExist, RoborockAccountDoesNotExist,
RoborockException, RoborockException,
@ -71,6 +72,7 @@ async def test_config_flow_success(
(RoborockException(), {"base": "unknown_roborock"}), (RoborockException(), {"base": "unknown_roborock"}),
(RoborockAccountDoesNotExist(), {"base": "invalid_email"}), (RoborockAccountDoesNotExist(), {"base": "invalid_email"}),
(RoborockInvalidEmail(), {"base": "invalid_email_format"}), (RoborockInvalidEmail(), {"base": "invalid_email_format"}),
(RoborockTooFrequentCodeRequests(), {"base": "too_frequent_code_requests"}),
(RoborockUrlException(), {"base": "unknown_url"}), (RoborockUrlException(), {"base": "unknown_url"}),
(Exception(), {"base": "unknown"}), (Exception(), {"base": "unknown"}),
], ],